AndrewShkrob/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

Fixed review notes

Browse source
This commit is contained in:
alexzatsepin 2016-09-15 17:08:06 +03:00
parent afbf9e33c3
commit 081e831dcb
8 changed files with 20 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

0
android/res/drawable/anim_spinner_pending_night.xml → android/res/drawable/anim_spinner_pending.xml
View file

5
android/res/layout/start_button.xml
View file

@ -2,11 +2,10 @@
<Button xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/start"
android:layout_width="wrap_content"
android:layout_width="@dimen/start_button_width"
android:layout_height="match_parent"
android:layout_gravity="center"
android:text="@string/p2p_start"
style="@style/MwmWidget.Button.Start"
android:padding="8dp"
android:textAppearance="@style/MwmTextAppearance.Body1"
tools:showIn="@layout/menu_route_plan_line" />
tools:showIn="@layout/menu_route_plan_line"/>

5
android/res/values-land/dimens.xml
View file

@ -13,4 +13,9 @@
<dimen name="nav_toggle_margin">16dp</dimen>
<dimen name="nav_numbers_margin">16dp</dimen>
<dimen name="nav_bottom_gap">24dp</dimen>
<!-- Altitude chart -->
<dimen name="altitude_chart_image_width">334dp</dimen>
<dimen name="start_button_width">128dp</dimen>
</resources>

2
android/res/values-w400dp/dimens.xml
View file

@ -5,5 +5,5 @@
<dimen name="routing_turns_padding">12dp</dimen>
<!-- Altitude chart -->
<dimen name="altitude_chart_image_width">600dp</dimen>
<dimen name="altitude_chart_image_width">400dp</dimen>
</resources>

5
android/res/values-w600dp/dimens.xml Normal file
View file

@ -0,0 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<!-- Altitude chart -->
<dimen name="altitude_chart_image_width">600dp</dimen>
</resources>

4
android/res/values/dimens.xml
View file

@ -47,6 +47,8 @@
<dimen name="width_dialog_base">300dp</dimen>
<dimen name="start_button_width">96dp</dimen>
<!-- direction fragment -->
<dimen name="margin_direction_small">8dp</dimen>
<dimen name="margin_direction_big">20dp</dimen>
@ -141,4 +143,6 @@
<dimen name="altitude_chart_image_height">40dp</dimen>
<dimen name="altitude_chart_image_width">232dp</dimen>
</resources>

4
android/res/values/themes-base.xml
View file

@ -65,7 +65,7 @@
<item name="menuBackgroundOpen">@color/bg_menu_open</item>
<item name="myPositionButtonAnimation">@drawable/anim_myposition_pending</item>
<item name="wheelPendingAnimation">@drawable/anim_spinner_pending_night</item>
<item name="wheelPendingAnimation">@drawable/anim_spinner_pending</item>
<item name="navButtonsTheme">@style/MwmTheme.NavButtons</item>
<item name="downloaderTheme">@style/MwmTheme.Downloader</item>
@ -142,7 +142,7 @@
<item name="menuBackgroundOpen">@color/bg_menu_open_night</item>
<item name="myPositionButtonAnimation">@drawable/anim_myposition_pending_night</item>
<item name="wheelPendingAnimation">@drawable/anim_spinner_pending_night</item>
<item name="wheelPendingAnimation">@drawable/anim_spinner_pending</item>
<item name="navButtonsTheme">@style/MwmTheme.NavButtons.Night</item>
<item name="downloaderTheme">@style/MwmTheme.Downloader.Night</item>

2
android/src/com/mapswithme/maps/routing/RoutingPlanController.java
View file

@ -115,7 +115,7 @@ public class RoutingPlanController extends ToolbarController
altitudeChartFrame = mActivity.findViewById(R.id.altitude_chart_panel);
mAltitudeChartFrame = altitudeChartFrame;
mAltitudeChartFrame.setVisibility(View.GONE);
UiUtils.hide(mAltitudeChartFrame);
mToggle.setImageDrawable(mToggleImage);
mToggle.setOnClickListener(new View.OnClickListener()