Fix warnings

indexer/data_header.hpp

@@ -62,7 +62,7 @@ namespace feature
     }
 
     inline size_t GetScalesCount() const { return m_scales.size(); }
-    inline int GetScale(int i) const { return static_cast<int>(m_scales[i]); }
+    inline int GetScale(size_t i) const { return static_cast<int>(m_scales[i]); }
     inline int GetLastScale() const { return m_scales.back(); }
 
     pair<int, int> GetScaleRange() const;

indexer/feature_altitude.hpp

@@ -111,7 +111,7 @@ public:
 
     for (size_t i = 0; i < pointCount; ++i)
     {
-      uint32_t const biasedDelta = coding::DeltaCoder::Decode(bits);
+      uint64_t const biasedDelta = coding::DeltaCoder::Decode(bits);
       if (biasedDelta == 0)
       {
         LOG(LERROR, ("Decoded altitude delta is zero. File", countryFileName,
@@ -119,7 +119,7 @@ public:
         m_altitudes.clear();
         return false;
       }
-      uint32_t const delta = biasedDelta - 1;
+      uint64_t const delta = biasedDelta - 1;
 
       m_altitudes[i] = static_cast<TAltitude>(bits::ZigZagDecode(delta) + prevAltitude);
       if (m_altitudes[i] < minAltitude)

indexer/feature_data.cpp

@@ -129,7 +129,7 @@ public:
 
 namespace feature
 {
-uint8_t CalculateHeader(uint32_t const typesCount, uint8_t const headerGeomType,
+uint8_t CalculateHeader(size_t const typesCount, uint8_t const headerGeomType,
                         FeatureParamsBase const & params)
 {
   ASSERT(typesCount != 0, ("Feature should have at least one type."));

indexer/feature_data.hpp

@@ -122,7 +122,7 @@ namespace feature
 
   string DebugPrint(TypesHolder const & holder);
 
-  uint8_t CalculateHeader(uint32_t const typesCount, uint8_t const headerGeomType,
+  uint8_t CalculateHeader(size_t const typesCount, uint8_t const headerGeomType,
                           FeatureParamsBase const & params);
 }  // namespace feature
 

platform/apple_location_service.mm

@@ -86,20 +86,16 @@ public:
 }
 
 - (void)locationManager:(CLLocationManager *)manager
-    didUpdateToLocation:(CLLocation *)newLocation
-           fromLocation:(CLLocation *)oldLocation
+     didUpdateLocations:(NSArray<CLLocation *> *)locations
 {
-  UNUSED_VALUE(manager);
-  UNUSED_VALUE(oldLocation);
   GpsInfo newInfo;
-  [LocationManagerWrapper location:newLocation toGpsInfo:newInfo];
+  [LocationManagerWrapper location:locations.firstObject toGpsInfo:newInfo];
   m_service->OnLocationUpdate(newInfo);
 }
 
 - (void)locationManager:(CLLocationManager *)manager
        didFailWithError:(NSError *)error
 {
-  UNUSED_VALUE(manager);
   LOG(LWARNING, ("locationManager failed with error", error.code, [error.description UTF8String]));
 
   if (error.code == kCLErrorDenied)

platform/platform_ios.mm

@@ -17,10 +17,6 @@
 #include <sys/stat.h>
 #include <sys/types.h>
 
-#if !defined(IFT_ETHER)
-#define IFT_ETHER 0x6 /* Ethernet CSMACD */
-#endif
-
 #import "iphone/Maps/Common/MWMCommon.h"
 
 #import "3party/Alohalytics/src/alohalytics_objc.h"
@@ -99,39 +95,6 @@ unique_ptr<ModelReader> Platform::GetReader(string const & file, string const &
 
 int Platform::VideoMemoryLimit() const { return 8 * 1024 * 1024; }
 int Platform::PreCachingDepth() const { return 2; }
-static string GetDeviceUid()
-{
-  NSString * uid = @"";
-  UIDevice * device = [UIDevice currentDevice];
-  if (device.systemVersion.floatValue >= 6.0 && device.identifierForVendor)
-    uid = [device.identifierForVendor UUIDString];
-  return [uid UTF8String];
-}
-
-static string GetMacAddress()
-{
-  string result;
-  // get wifi mac addr
-  ifaddrs * addresses = NULL;
-  if (getifaddrs(&addresses) == 0 && addresses != NULL)
-  {
-    ifaddrs * currentAddr = addresses;
-    do
-    {
-      if (currentAddr->ifa_addr->sa_family == AF_LINK &&
-          ((const struct sockaddr_dl *)currentAddr->ifa_addr)->sdl_type == IFT_ETHER)
-      {
-        const struct sockaddr_dl * dlAddr = (const struct sockaddr_dl *)currentAddr->ifa_addr;
-        const char * base = &dlAddr->sdl_data[dlAddr->sdl_nlen];
-        result.assign(base, dlAddr->sdl_alen);
-        break;
-      }
-      currentAddr = currentAddr->ifa_next;
-    } while (currentAddr->ifa_next);
-    freeifaddrs(addresses);
-  }
-  return result;
-}
 
 string Platform::UniqueClientId() const { return [Alohalytics installationId].UTF8String; }
 static void PerformImpl(void * obj)

platform/socket.hpp

@@ -30,11 +30,11 @@ class StubSocket final : public Socket
 {
 public:
   // Socket overrides:
-  bool Open(string const & host, uint16_t port) override { return false; }
+  bool Open(string const &, uint16_t) override { return false; }
   void Close() override {}
-  bool Read(uint8_t * data, uint32_t count) override { return false; }
-  bool Write(uint8_t const * data, uint32_t count) override { return false; }
-  void SetTimeout(uint32_t milliseconds) override {}
+  bool Read(uint8_t *, uint32_t) override { return false; }
+  bool Write(uint8_t const *, uint32_t) override { return false; }
+  void SetTimeout(uint32_t) override {}
 };
 
 unique_ptr<Socket> CreateSocket();