From 3aaed3bd32ad0d82813d2ec1c53771053041c1b6 Mon Sep 17 00:00:00 2001 From: Daria Volvenkova Date: Thu, 30 Apr 2020 17:56:52 +0300 Subject: [PATCH] Review fix. Crash fix. --- .../src/com/mapswithme/maps/maplayer/guides/GuidesState.java | 3 ++- iphone/CoreApi/CoreApi/Traffic/MWMMapOverlayManager.mm | 2 ++ map/guides_manager.cpp | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/android/src/com/mapswithme/maps/maplayer/guides/GuidesState.java b/android/src/com/mapswithme/maps/maplayer/guides/GuidesState.java index 2bd8e3de3f..1b03127ba3 100644 --- a/android/src/com/mapswithme/maps/maplayer/guides/GuidesState.java +++ b/android/src/com/mapswithme/maps/maplayer/guides/GuidesState.java @@ -18,7 +18,8 @@ public enum GuidesState Toast.makeText(context, R.string.no_routes_in_the_area_toast, Toast.LENGTH_SHORT).show(); } }, - NETWORK_ERROR; + NETWORK_ERROR, + FATAL_NETWORK_ERROR; public void activate(@NonNull Context context) { diff --git a/iphone/CoreApi/CoreApi/Traffic/MWMMapOverlayManager.mm b/iphone/CoreApi/CoreApi/Traffic/MWMMapOverlayManager.mm index 9ecce9453b..fd1b04d738 100644 --- a/iphone/CoreApi/CoreApi/Traffic/MWMMapOverlayManager.mm +++ b/iphone/CoreApi/CoreApi/Traffic/MWMMapOverlayManager.mm @@ -122,6 +122,8 @@ static NSString *kGuidesWasShown = @"guidesWasShown"; return MWMMapOverlayGuidesStateNoData; case GuidesManager::GuidesState::NetworkError: return MWMMapOverlayGuidesStateNetworkError; + case GuidesManager::GuidesState::FatalNetworkError: + return MWMMapOverlayGuidesStateNetworkError; } } diff --git a/map/guides_manager.cpp b/map/guides_manager.cpp index 63975a3841..7992253f2a 100644 --- a/map/guides_manager.cpp +++ b/map/guides_manager.cpp @@ -328,7 +328,8 @@ void GuidesManager::UpdateGuideSelection() if (mark->GetGuideId() == m_activeGuide) { es.CreateUserMark(mark->GetPivot()); - break; + return; } } + m_activeGuide.clear(); }