[android] Fix Google Play metadata checks

Follow up e1e2510071

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>

android/build.gradle

@@ -494,8 +494,8 @@ huaweiPublish {
           'ta-IN': 'ta_IN',
           'te-IN': 'te_IN',
       ]
-      def files = fileTree(dir: "$projectDir/src/google/play/release-notes",
-          include: '**/default.txt')
+      def files = fileTree(dir: "$projectDir/src/fdroid/play/listings",
+          include: '**/release-notes.txt')
       files.each { File file ->
         def path = file.getPath()
         def locale = file.parentFile.getName()

android/src/fdroid/play/listings/be/release-notes.txt

@@ -8,4 +8,4 @@
 • Харватыя дададзена ў Шэнгенскую зону
 • Павялічана максімальная колькасць рэдагуемых паверхаў будынкаў да 50
 • TTS: уключаны беларуская і некаторыя іншыя мовы
-…падрабязней: omaps.app/news
+…падрабязней: omaps.app/news

android/src/fdroid/play/listings/es-ES/title-google.txt

@@ -0,0 +1 @@
+OrganicMaps: GPS sin conexión

android/src/fdroid/play/listings/eu-ES/title-google.txt

@@ -0,0 +1 @@
+Organic Maps: offline GPS

android/src/fdroid/play/listings/fr-FR/release-notes.txt

@@ -7,4 +7,4 @@
 • Ajout de la Croatie à l'espace Schengen
 • Augmentation du nombre d'étages modifiables sur un bâtiment de 25 à 50
 • Activation du Basque, Biélorusse, Croate, Norvégien, Marathi, Souahili dans TTS.
-…Plus sur : omaps.app/news
+…Plus: omaps.app/news

android/src/fdroid/play/listings/uk/release-notes.txt

@@ -8,4 +8,4 @@
 • Хорватія додана до Шенгенської зони
 • Збільшено максимальну кількість редагованих поверхів будівель до 50
 • TTS: включені білоруська та деякі інші мови
-…докладніше: omaps.app/news
+…докладніше: omaps.app/news

android/src/fdroid/play/listings/zh-TW/title-google.txt

@@ -0,0 +1 @@
+Organic Maps 離線登山、單車與 GPS 導航

tools/python/check_store_metadata.py

@@ -134,12 +134,14 @@ def check_raw(path, max_length):
             ok = error(path, "too long: got={}, expected={}", cur_length, max_length)
         return ok, text
 
-def check_text(path, max):
+def check_text(path, max, optional=False):
     try:
         return done(path, check_raw(path, max)[0])
     except FileNotFoundError as e:
+        if optional:
+            return True,
         print("🚫", path)
-        return True,
+        return False,
 
 def check_url(path,):
     (ok, url) = check_raw(path, 500)
@@ -159,22 +161,28 @@ def check_exact(path, expected):
         ok = error(path, "invalid value: got={}, expected={}", value, expected)
     return done(path, ok)
 
+
 def check_android():
     ok = True
-    for flavor in glob.glob('android/src/*/play/'):
-        ok = check_url(flavor + "contact-website.txt") and ok
-        ok = check_email(flavor + "contact-email.txt") and ok
-        ok = check_exact(flavor + "default-language.txt", "en-US") and ok
-        maxTitle = 30 if 'google' in flavor else 50
-        for locale in glob.glob(flavor + 'listings/*/'):
-            if locale.split('/')[-2] not in GPLAY_LOCALES:
-                ok = error(locale, "unsupported locale") and ok
-                continue
-            ok = check_text(locale + "title.txt", maxTitle) and ok
-            ok = check_text(locale + "short-description.txt", 80) and ok
-            ok = check_text(locale + "full-description.txt", 4000) and ok
-        for locale in glob.glob(flavor + 'release-notes/??-??/'):
-            ok = check_text(locale + "default.txt", 500) and ok
+    flavor = 'android/src/fdroid/play/'
+    ok = check_url(flavor + 'contact-website.txt') and ok
+    ok = check_email(flavor + 'contact-email.txt') and ok
+    ok = check_exact(flavor + 'default-language.txt', 'en-US') and ok
+    for locale in glob.glob(flavor + 'listings/*/'):
+        if locale.split('/')[-2] not in GPLAY_LOCALES:
+            ok = error(locale, 'unsupported locale') and ok
+            continue
+        ok = check_text(locale + 'title.txt', 50) and ok
+        ok = check_text(locale + 'title-google.txt', 30) and ok
+        ok = check_text(locale + 'short-description.txt', 80) and ok
+        ok = check_text(locale + 'short-description-google.txt', 80, True) and ok
+        ok = check_text(locale + 'full-description.txt', 4000) and ok
+        ok = check_text(locale + 'full-description-google.txt', 4000, True) and ok
+    for locale in glob.glob(flavor + 'release-notes/*/'):
+        if locale.split('/')[-2] not in GPLAY_LOCALES:
+            ok = error(locale, 'unsupported locale') and ok
+            continue
+        ok = check_text(locale + 'default.txt', 500) and ok
     return ok
 
 
@@ -206,8 +214,7 @@ def check_ios():
         ok = check_text(locale + "promotional_text.txt", 170) and ok
         ok = check_text(locale + "description.txt", 4000) and ok
         ok = check_text(locale + "release_notes.txt", 4000) and ok
-        if os.path.exists(locale + "keywords.txt"):
-           ok = check_text(locale + "keywords.txt", 100) and ok
+        ok = check_text(locale + "keywords.txt", 100, True) and ok
         ok = check_url(locale + "support_url.txt") and ok
         ok = check_url(locale + "marketing_url.txt") and ok
         ok = check_url(locale + "privacy_url.txt") and ok