AndrewShkrob/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] Show a toast every time FS mode is entered

Browse source 
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
This commit is contained in:
Konstantin Pastbin 2024-12-19 14:08:06 +03:00
parent 4c41eb5816
commit b6cc1d57fa
2 changed files with 3 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
android/app/src/main/java/app/organicmaps/MwmActivity.java
View file

@ -1287,7 +1287,9 @@ public class MwmActivity extends BaseMwmFragmentActivity
if (isFullscreen())
{
closePlacePage();
showFullscreenToastIfNeeded();
// Show the toast every time so that users don't forget and don't get trapped in the FS mode.
// TODO(pastk): there are better solutions, see https://github.com/organicmaps/organicmaps/issues/9344
Toast.makeText(this, R.string.long_tap_toast, Toast.LENGTH_LONG).show();
}
}
@ -1309,16 +1311,6 @@ public class MwmActivity extends BaseMwmFragmentActivity
Framework.nativeGetChoosePositionMode() == Framework.ChoosePositionMode.NONE;
}
private void showFullscreenToastIfNeeded()
{
// Show the toast only once so new behaviour doesn't confuse users
if (!Config.wasLongTapToastShown(this))
{
Toast.makeText(this, R.string.long_tap_toast, Toast.LENGTH_LONG).show();
Config.setLongTapToastShown(this, true);
}
}
@Override
public boolean onTouch(View view, MotionEvent event)
{

13
android/app/src/main/java/app/organicmaps/util/Config.java
View file

@ -35,7 +35,6 @@ public final class Config
private static final String KEY_MISC_AGPS_TIMESTAMP = "AGPSTimestamp";
private static final String KEY_DONATE_URL = "DonateUrl";
private static final String KEY_PREF_SEARCH_HISTORY = "SearchHistoryEnabled";
private static final String KEY_PREF_LONG_TAP_TOAST_SHOWN = "LongTapToastShown";
/**
* The total number of app launches.
@ -417,18 +416,6 @@ public final class Config
.apply();
}
public static boolean wasLongTapToastShown(@NonNull Context context)
{
return MwmApplication.prefs(context).getBoolean(KEY_PREF_LONG_TAP_TOAST_SHOWN, false);
}
public static void setLongTapToastShown(@NonNull Context context, Boolean newValue)
{
MwmApplication.prefs(context).edit()
.putBoolean(KEY_PREF_LONG_TAP_TOAST_SHOWN, newValue)
.apply();
}
public static boolean isSearchHistoryEnabled()
{
return getBool(KEY_PREF_SEARCH_HISTORY, true);