AndrewShkrob/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] Remove space for icons in Settings (#1924)

Browse source 
* [android] Remove space for icons in Settings

Override the the iconSpaceReserved property specified in
https://cs.android.com/android/platform/superproject/+/android-12.0.0_r4:prebuilts/sdk/current/support/v7/preference/res/values-sw360dp-v13/values-sw360dp-v13.xml
as none of the Settings items has an icon; hence the space is wasted and
leads to the truncation of item names and descriptions.

Closes: #1872
Signed-off-by: Stefan Löffler <st.loeffler@gmail.com>

* [android] Add comment about iconSpaceReserved

Signed-off-by: Stefan Löffler <st.loeffler@gmail.com>
This commit is contained in:
Stefan Löffler 2022-01-23 22:08:37 +01:00 • committed by GitHub
parent 98090dc16a
commit f4ad65b8be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
android/res/values-sw360dp-v13/values-preference.xml Normal file
View file

@ -0,0 +1,20 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
Items in the Preferences can have space reserved for an icon. As none of the
settings currently have associated icons, this leads to items that seem indented
without purpose. This wastes space and can lead to truncation of the item names
and descriptions. See https://github.com/organicmaps/organicmaps/issues/1872
To rectify this, the iconSpaceReserved property needs to be set to false.
According to https://developer.android.com/reference/android/preference/Preference#attr_android:iconSpaceReserved
false should be the default. However, according to
https://material.io/design/platform-guidance/android-settings.html this goes
against the material design guidelines and the default was overridden to true in
https://cs.android.com/android/platform/superproject/+/android-9.0.0_r1:prebuilts/sdk/current/support/v7/preference/res/values-sw360dp-v13/values-sw360dp-v13.xml
This file sets the default value back to false (i.e. no space reserved for icons).
See also the discussion at https://github.com/organicmaps/organicmaps/pull/1924
-->
<resources>
<bool name="config_materialPreferenceIconSpaceReserved">false</bool>
</resources>