Compare commits

...
Sign in to create a new pull request.

1 commit

Author SHA1 Message Date
0a61e8f346 [android] Don't change the viewport when PlacePage is opened
This code doesn't bring any real value, but definetly creates troubles.

Closes #4794

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>
2023-04-23 13:09:03 +03:00
2 changed files with 0 additions and 19 deletions

View file

@ -95,8 +95,6 @@ public class PlacePageController implements Initializable<Activity>,
if (PlacePageUtils.isSettlingState(newState) || PlacePageUtils.isDraggingState(newState))
return;
PlacePageUtils.moveViewportUp(mPlacePage, mViewportMinHeight);
if (PlacePageUtils.isHiddenState(newState))
onHiddenInternal();
}
@ -184,7 +182,6 @@ public class PlacePageController implements Initializable<Activity>,
if (mDeactivateMapSelection)
Framework.nativeDeactivatePopup();
mDeactivateMapSelection = true;
PlacePageUtils.moveViewportUp(mPlacePage, mViewportMinHeight);
resetPlacePageHeightBounds();
removePlacePageFragments();
}
@ -302,7 +299,6 @@ public class PlacePageController implements Initializable<Activity>,
mSlideListener.onPlacePageSlide(mDistanceToTop);
if (value == peekHeight)
{
PlacePageUtils.moveViewportUp(mPlacePage, mViewportMinHeight);
setPlacePageHeightBounds();
}
});

View file

@ -17,21 +17,6 @@ import java.util.List;
class PlacePageUtils
{
static void moveViewportUp(@NonNull View placePageView, int viewportMinHeight)
{
placePageView.post(() -> {
final View coordinatorLayout = (ViewGroup) placePageView.getParent();
final int viewPortWidth = coordinatorLayout.getWidth();
int viewPortHeight = coordinatorLayout.getHeight();
Rect sheetRect = new Rect();
placePageView.getGlobalVisibleRect(sheetRect);
viewPortHeight -= sheetRect.height();
if (viewPortHeight >= viewportMinHeight)
Framework.nativeSetVisibleRect(0, 0, viewPortWidth, viewPortHeight);
});
}
static boolean isSettlingState(@BottomSheetBehavior.State int state)
{
return state == BottomSheetBehavior.STATE_SETTLING;