From 30e835a8518d34126e1f4f379106e13eaa3b778d Mon Sep 17 00:00:00 2001
From: Vladimir Byko-Ianko <v.bykoianko@corp.mail.ru>
Date: Wed, 27 May 2020 17:49:36 +0300
Subject: [PATCH] [tracking] Wrong packet tests.

---
 tracking/protocol.cpp                     |  2 +-
 tracking/tracking_tests/protocol_test.cpp | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/tracking/protocol.cpp b/tracking/protocol.cpp
index 355047d301..984ede9f33 100644
--- a/tracking/protocol.cpp
+++ b/tracking/protocol.cpp
@@ -121,7 +121,7 @@ Protocol::DataElementsVec Protocol::DecodeDataPacket(PacketType type, vector<uin
   }
   catch (Reader::SizeException const & ex)
   {
-    LOG(LERROR, ("Wrong packet. SizeException. Msg:", ex.Msg(), ". What:", ex.what()));
+    LOG(LWARNING, ("Wrong packet. SizeException. Msg:", ex.Msg(), ". What:", ex.what()));
     return {};
   }
 }
diff --git a/tracking/tracking_tests/protocol_test.cpp b/tracking/tracking_tests/protocol_test.cpp
index d90e567b49..631013e5f8 100644
--- a/tracking/tracking_tests/protocol_test.cpp
+++ b/tracking/tracking_tests/protocol_test.cpp
@@ -108,3 +108,22 @@ UNIT_TEST(Protocol_DecodeDataPacket)
   DecodeDataPacketVersionTest(points, Protocol::PacketType::DataV0);
   DecodeDataPacketVersionTest(points, Protocol::PacketType::DataV1);
 }
+
+UNIT_TEST(Protocol_DecodeWrongDataPacket)
+{
+  vector<vector<uint8_t>> payloads = {
+      vector<uint8_t>{},
+      vector<uint8_t>{0x25},
+      vector<uint8_t>{0x0},
+      vector<uint8_t>{0x0, 0x0, 0x23, 0xFF},
+      vector<uint8_t>{0xFF, 0x1, 0x23, 0xFF, 0x1, 0x0, 0x27, 0x63, 0x32, 0x9, 0xFF},
+  };
+  for (auto const packetType : {Protocol::PacketType::DataV0, Protocol::PacketType::DataV1})
+  {
+    for (auto const & payload : payloads)
+    {
+      auto result = Protocol::DecodeDataPacket(packetType, payload);
+      TEST(result.empty(), (packetType, payload));
+    }
+  }
+}