RedAuburn/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] Changed stats, removed useless events

Browse source
This commit is contained in:
Dmitry Donskoy 2019-04-18 17:01:13 +03:00 • committed by Aleksandr Zatsepin
parent a098885047
commit 8355d61875
4 changed files with 3 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
android/src/com/mapswithme/maps/MwmActivity.java
View file

@ -928,7 +928,6 @@ public class MwmActivity extends BaseMwmFragmentActivity
{
mPlacePageController.close();
RoutingOptions.removeOption(roadType);
Statistics.INSTANCE.trackSettingsDriveOptionsChangeEvent(Statistics.EventParam.ROUTE);
rebuildLastRouteInternal();
}

10
android/src/com/mapswithme/maps/routing/RoutingController.java
View file

@ -47,9 +47,6 @@ import static com.mapswithme.util.statistics.Statistics.EventName.ROUTING_POINT_
public class RoutingController implements TaxiManager.TaxiListener
{
private static final String TAG = RoutingController.class.getSimpleName();
private static final int ERROR_TYPE_IMPOSSIBLE_DEST = 0;
private static final int ERROR_TYPE_IMPOSSIBLE_OPTIONS = 1;
private static final int ERROR_TYPE_MISSED_MWM = 3;
private enum State
{
@ -200,8 +197,6 @@ public class RoutingController implements TaxiManager.TaxiListener
return;
mContainsCachedResult = false;
Statistics.INSTANCE.trackDriveSettingsStatus();
if (mLastResultCode == ResultCodesHelper.NO_ERROR || mLastResultCode == ResultCodesHelper.HAS_WARNINGS)
{
updatePlan();
@ -218,20 +213,15 @@ public class RoutingController implements TaxiManager.TaxiListener
if (ResultCodesHelper.isMoreMapsNeeded(mLastResultCode))
{
mContainer.onBuildError(mLastResultCode, mLastMissingMaps);
Statistics.INSTANCE.trackRoutingBuildError(ERROR_TYPE_MISSED_MWM);
return;
}
setBuildState(BuildState.ERROR);
mLastBuildProgress = 0;
Statistics.INSTANCE.trackRoutingBuildError(ERROR_TYPE_IMPOSSIBLE_DEST);
updateProgress();
if (RoutingOptions.hasAnyOptions())
{
mContainer.onCalculateRouteError();
Statistics.INSTANCE.trackRoutingBuildError(ERROR_TYPE_IMPOSSIBLE_OPTIONS);
}
}
private void setState(State newState)

2
android/src/com/mapswithme/maps/settings/DrivingOptionsFragment.java
View file

@ -124,7 +124,7 @@ public class DrivingOptionsFragment extends BaseMwmToolbarFragment
else
RoutingOptions.removeOption(mRoadType);
Statistics.INSTANCE.trackSettingsDriveOptionsChangeEvent(Statistics.EventParam.SETTINGS);
Statistics.INSTANCE.trackSettingsDriveOptionsChangeEvent();
}
}
}

19
android/src/com/mapswithme/util/statistics/Statistics.java
View file

@ -218,13 +218,6 @@ public enum Statistics
Statistics.ParamValue.SHARING_OPTIONS));
}
public void trackDriveSettingsStatus()
{
ParameterBuilder status = getRoutingOptionsStatus();
trackEvent(Statistics.EventName.SETTINGS_DRIVE_OPTIONS_STATUS,
status);
}
@NonNull
private ParameterBuilder getRoutingOptionsStatus()
{
@ -240,16 +233,10 @@ public enum Statistics
.add(EventParam.UNPAVED, hasDirty ? 1 : 0);
}
public void trackRoutingBuildError(int errorType)
{
Statistics.ParameterBuilder builder = new Statistics.ParameterBuilder();
trackEvent(Statistics.EventName.ROUTING_BUILD_ERROR, builder.add(EventParam.ERROR, errorType));
}
public void trackSettingsDriveOptionsChangeEvent(@NonNull String source)
public void trackSettingsDriveOptionsChangeEvent()
{
ParameterBuilder parameterBuilder = getRoutingOptionsStatus();
parameterBuilder.add(EventParam.FROM, source);
parameterBuilder.add(EventParam.FROM, EventParam.SETTINGS);
trackEvent(EventName.SETTINGS_DRIVE_OPTIONS_CHANGE,
parameterBuilder);
@ -323,8 +310,6 @@ public enum Statistics
public static final String BM_GUIDEDOWNLOADTOAST_SHOWN = "Bookmarks_GuideDownloadToast_shown";
public static final String BM_GUIDES_DOWNLOADDIALOGUE_CLICK = "Bookmarks_Guides_DownloadDialogue_click";
public static final String SETTINGS_DRIVE_OPTIONS_CHANGE = "Settings_Navigation_DrivingOptions_change";
public static final String SETTINGS_DRIVE_OPTIONS_STATUS = "Settings_Navigation_DrivingOptions_status";
public static final String ROUTING_BUILD_ERROR = "Routing_build_error";
public static final String PP_DRIVING_OPTIONS_ACTION = "Placepage_DrivingOptions_action";
// search