From 8d2d8d3c80c14a27817cdc92555ca3d93f222924 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ferenc=20G=C3=A9czi?= Date: Sun, 15 Dec 2024 00:00:00 +0000 Subject: [PATCH] Fix review comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Ferenc Géczi --- indexer/map_style.cpp | 8 ++++++-- qt/draw_widget.cpp | 6 +++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/indexer/map_style.cpp b/indexer/map_style.cpp index 4a60dcc25f..f44dd87807 100644 --- a/indexer/map_style.cpp +++ b/indexer/map_style.cpp @@ -57,6 +57,10 @@ std::string DebugPrint(MapStyle mapStyle) bool MapStyleIsDark(MapStyle mapStyle) { - const std::unordered_set darkStyles {MapStyle::MapStyleDefaultDark, MapStyle::MapStyleVehicleDark, MapStyle::MapStyleOutdoorsDark}; - return darkStyles.contains(mapStyle); + for (const auto darkStyle : {MapStyleDefaultDark, MapStyleVehicleDark, MapStyleOutdoorsDark}) + { + if (mapStyle == darkStyle) + return true; + } + return false; } diff --git a/qt/draw_widget.cpp b/qt/draw_widget.cpp index 26110c6874..1991e8288f 100644 --- a/qt/draw_widget.cpp +++ b/qt/draw_widget.cpp @@ -770,19 +770,19 @@ void DrawWidget::RefreshDrawingRules() void DrawWidget::SetMapStyleToDefault() { - auto style = m_framework.GetMapStyle(); + auto const style = m_framework.GetMapStyle(); SetMapStyle(MapStyleIsDark(style) ? MapStyle::MapStyleDefaultDark : MapStyle::MapStyleDefaultLight); } void DrawWidget::SetMapStyleToVehicle() { - auto style = m_framework.GetMapStyle(); + auto const style = m_framework.GetMapStyle(); SetMapStyle(MapStyleIsDark(style) ? MapStyle::MapStyleVehicleDark : MapStyle::MapStyleVehicleLight); } void DrawWidget::SetMapStyleToOutdoors() { - auto style = m_framework.GetMapStyle(); + auto const style = m_framework.GetMapStyle(); SetMapStyle(MapStyleIsDark(style) ? MapStyle::MapStyleOutdoorsDark : MapStyle::MapStyleOutdoorsLight); }