Review fixes.

This commit is contained in:
Daria Volvenkova 2016-05-19 11:00:40 +03:00
parent ffb32f2f1e
commit ada639df3c
5 changed files with 12 additions and 12 deletions

View file

@ -3,10 +3,10 @@
namespace df
{
ArrowAnimation::ArrowAnimation(m2::PointD const & startPos, m2::PointD const & endPos,
double startAngle, double endAngle, ScreenBase const & convertor)
ArrowAnimation::ArrowAnimation(m2::PointD const & startPos, m2::PointD const & endPos, double moveDuration,
double startAngle, double endAngle)
: Animation(true /* couldBeInterrupted */, true /* couldBeBlended */)
, m_positionInterpolator(startPos, endPos, convertor)
, m_positionInterpolator(moveDuration, 0.0 /* delay */, startPos, endPos)
, m_angleInterpolator(startAngle, endAngle)
{
m_objects.insert(Animation::MyPositionArrow);

View file

@ -9,8 +9,8 @@ namespace df
class ArrowAnimation : public Animation
{
public:
ArrowAnimation(m2::PointD const & startPos, m2::PointD const & endPos,
double startAngle, double endAngle, ScreenBase const & convertor);
ArrowAnimation(m2::PointD const & startPos, m2::PointD const & endPos, double moveDuration,
double startAngle, double endAngle);
Animation::Type GetType() const override { return Animation::Arrow; }

View file

@ -9,7 +9,7 @@ namespace df
double CalcAnimSpeedDuration(double pxDiff, double pxSpeed)
{
double const kEps = 1e-5;
double constexpr kEps = 1e-5;
if (my::AlmostEqualAbs(pxDiff, 0.0, kEps))
return 0.0;

View file

@ -9,7 +9,7 @@ class Interpolator
{
public:
Interpolator(double duration, double delay = 0);
virtual ~Interpolator(){}
virtual ~Interpolator() = default;
virtual void Advance(double elapsedSeconds);
virtual void Finish();

View file

@ -630,10 +630,10 @@ void MyPositionController::CreateAnim(m2::PointD const & oldPos, double oldAzimu
{
if (IsModeChangeViewport())
{
m_animCreator = [this, oldPos, oldAzimut, screen]()
m_animCreator = [this, oldPos, oldAzimut, moveDuration]()
{
AnimationSystem::Instance().CombineAnimation(make_unique_dp<ArrowAnimation>(oldPos, m_position, oldAzimut,
m_drawDirection, screen));
AnimationSystem::Instance().CombineAnimation(make_unique_dp<ArrowAnimation>(oldPos, m_position, moveDuration,
oldAzimut, m_drawDirection));
};
m_oldPosition = oldPos;
m_oldDrawDirection = oldAzimut;
@ -641,8 +641,8 @@ void MyPositionController::CreateAnim(m2::PointD const & oldPos, double oldAzimu
}
else
{
AnimationSystem::Instance().CombineAnimation(make_unique_dp<ArrowAnimation>(oldPos, m_position, oldAzimut,
m_drawDirection, screen));
AnimationSystem::Instance().CombineAnimation(make_unique_dp<ArrowAnimation>(oldPos, m_position, moveDuration,
oldAzimut, m_drawDirection));
}
}
}