RedAuburn/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

Fix invalid memory usage in MemWriter

Browse source 
Case 1: `m_Data.size() == 0 && m_Pos == 0` => `resize` is not called.
Case 2: `size == 0` => access to `m_Data[m_Data.size()]`

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
This commit is contained in:
Osyotr 2023-12-24 18:57:51 +03:00 • committed by Viktor Govako
parent 863c755894
commit ae7027a36f
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
coding/writer.hpp
View file

@ -61,8 +61,11 @@ public:
void Write(void const * p, size_t size) override
{
if (size == 0)
return;
auto freeSize = static_cast<intptr_t>(m_Data.size() - m_Pos);
if (freeSize < 0)
if (freeSize <= 0)
{
m_Data.resize(static_cast<size_t>(m_Pos + size));
freeSize = size;