From d860df1f4bf477467dafb8f5a9cb07c1001228da Mon Sep 17 00:00:00 2001 From: alexzatsepin Date: Tue, 11 Apr 2017 15:53:48 +0300 Subject: [PATCH 1/2] [android[release-72/master] Added unregistration of previous ad when it's changed --- .../com/mapswithme/maps/ads/FacebookNativeAd.java | 6 ++++++ .../src/com/mapswithme/maps/ads/MwmNativeAd.java | 5 +++++ .../com/mapswithme/maps/ads/MyTargetNativeAd.java | 6 ++++++ .../maps/widget/placepage/BannerController.java | 14 +++++++++++++- 4 files changed, 30 insertions(+), 1 deletion(-) diff --git a/android/src/com/mapswithme/maps/ads/FacebookNativeAd.java b/android/src/com/mapswithme/maps/ads/FacebookNativeAd.java index cef0148ef5..5ce992f02a 100644 --- a/android/src/com/mapswithme/maps/ads/FacebookNativeAd.java +++ b/android/src/com/mapswithme/maps/ads/FacebookNativeAd.java @@ -57,6 +57,12 @@ class FacebookNativeAd extends CachedMwmNativeAd NativeAd.downloadAndDisplayImage(mAd.getAdIcon(), (ImageView) view); } + @Override + public void unregisterView() + { + mAd.unregisterView(); + } + @Override void registerViewForInteraction(@NonNull View view) { diff --git a/android/src/com/mapswithme/maps/ads/MwmNativeAd.java b/android/src/com/mapswithme/maps/ads/MwmNativeAd.java index 650b44d97d..5f1dcf9e07 100644 --- a/android/src/com/mapswithme/maps/ads/MwmNativeAd.java +++ b/android/src/com/mapswithme/maps/ads/MwmNativeAd.java @@ -33,6 +33,11 @@ public interface MwmNativeAd */ void registerView(@NonNull View bannerView); + /** + * Unregisters the view attached to the current ad. + */ + void unregisterView(); + /** * Returns a provider name for this ad. */ diff --git a/android/src/com/mapswithme/maps/ads/MyTargetNativeAd.java b/android/src/com/mapswithme/maps/ads/MyTargetNativeAd.java index e9029600d9..fbff49b6a4 100644 --- a/android/src/com/mapswithme/maps/ads/MyTargetNativeAd.java +++ b/android/src/com/mapswithme/maps/ads/MyTargetNativeAd.java @@ -64,6 +64,12 @@ class MyTargetNativeAd extends CachedMwmNativeAd NativeAd.loadImageToView(icon, (ImageView) view); } + @Override + public void unregisterView() + { + mAd.unregisterView(); + } + @Override void registerViewForInteraction(@NonNull View view) { diff --git a/android/src/com/mapswithme/maps/widget/placepage/BannerController.java b/android/src/com/mapswithme/maps/widget/placepage/BannerController.java index 9ef2ebdd86..2055fe5787 100644 --- a/android/src/com/mapswithme/maps/widget/placepage/BannerController.java +++ b/android/src/com/mapswithme/maps/widget/placepage/BannerController.java @@ -143,7 +143,7 @@ final class BannerController if (mBanners != null && !mBanners.equals(banners)) { onChangedVisibility(false); - mCurrentAd = null; + unregisterCurrentAd(); } UiUtils.hide(mFrame); @@ -162,6 +162,16 @@ final class BannerController updateVisibility(); } + private void unregisterCurrentAd() + { + if (mCurrentAd != null) + { + LOGGER.d(TAG, "Unregister view for the ad: " + mCurrentAd.getTitle()); + mCurrentAd.unregisterView(); + mCurrentAd = null; + } + } + boolean isBannerVisible() { return !UiUtils.isHidden(mFrame); @@ -302,6 +312,8 @@ final class BannerController if (mBanners == null) return; + unregisterCurrentAd(); + mCurrentAd = ad; updateVisibility(); From d5c1be33b120888703d57eb1cf812ca640a2cfef Mon Sep 17 00:00:00 2001 From: alexzatsepin Date: Tue, 11 Apr 2017 16:53:08 +0300 Subject: [PATCH 2/2] [android] Update version to 7.2.4 --- android/gradle.properties | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/gradle.properties b/android/gradle.properties index 9791ff98a7..390096495e 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -4,8 +4,8 @@ propMinSdkVersion=15 propTargetSdkVersion=22 propCompileSdkVersion=23 propBuildToolsVersion=25.0.2 -propVersionCode=723 -propVersionName=7.2.3 +propVersionCode=724 +propVersionName=7.2.4 propDebugNdkFlags=V=1 NDK_DEBUG=1 DEBUG=1 propReleaseNdkFlags=V=1 NDK_DEBUG=0 PRODUCTION=1 org.gradle.daemon=true