From e8d4da6905237d184bde85e3b9e8be4cfc536a61 Mon Sep 17 00:00:00 2001 From: tatiana-yan Date: Wed, 25 Dec 2019 18:42:44 +0300 Subject: [PATCH] [partners_api] Remove not existing type from partners_api. --- partners_api/mopub_ads.cpp | 2 -- .../partners_api_tests/ads_engine_tests.cpp | 17 ----------------- partners_api/rb_ads.cpp | 2 -- 3 files changed, 21 deletions(-) diff --git a/partners_api/mopub_ads.cpp b/partners_api/mopub_ads.cpp index d424061cc6..854518b8e7 100644 --- a/partners_api/mopub_ads.cpp +++ b/partners_api/mopub_ads.cpp @@ -69,8 +69,6 @@ Mopub::Mopub() {"amenity", "bureau_de_change"}}, kNonTourismPlacementId); - AppendEntry({{"sponsored", "banner"}}, kSponsoredBannerPlacementId); - for (auto const & p : GetPartners()) { auto const & placementId = p.GetBannerPlacementId(); diff --git a/partners_api/partners_api_tests/ads_engine_tests.cpp b/partners_api/partners_api_tests/ads_engine_tests.cpp index f87b631b9b..977ea3b7f6 100644 --- a/partners_api/partners_api_tests/ads_engine_tests.cpp +++ b/partners_api/partners_api_tests/ads_engine_tests.cpp @@ -136,23 +136,6 @@ UNIT_TEST(AdsEngine_Smoke) auto result = engine.GetBanners(holder, {"Russian Federation"}, "ru"); TEST(result.empty(), ()); } - ads::Google google; - { - feature::TypesHolder holder; - holder.Assign(c.GetTypeByPath({"sponsored", "banner"})); - TEST(engine.HasBanner(holder, {"Russian Federation"}, "ru"), ()); - auto result = engine.GetBanners(holder, {"Russian Federation"}, "ru"); - TEST(!result.empty(), ()); - CheckIds(result, {"2bab47102d38485996788ab9b602ce2c"}); - } - { - feature::TypesHolder holder; - holder.Assign(c.GetTypeByPath({"sponsored", "banner"})); - TEST(engine.HasBanner(holder, {"United States"}, "en"), ()); - auto result = engine.GetBanners(holder, {"United States"}, "en"); - TEST(!result.empty(), ()); - CheckIds(result, {"2bab47102d38485996788ab9b602ce2c"}); - } ads::Facebook facebook; { TEST(engine.HasSearchBanner(), ()); diff --git a/partners_api/rb_ads.cpp b/partners_api/rb_ads.cpp index d24ab87c22..9cb46b084c 100644 --- a/partners_api/rb_ads.cpp +++ b/partners_api/rb_ads.cpp @@ -84,8 +84,6 @@ Rb::Rb() AppendEntry({{"building"}}, kBuildingPlacementId); - AppendExcludedTypes({{"sponsored", "banner"}}); - AppendSupportedCountries(kSupportedCountries); AppendSupportedUserLanguages(kSupportedLanguages); }