From fa1d1c27c23492adfbbfc7ef54e1dbc4d899f542 Mon Sep 17 00:00:00 2001
From: Alexander Marchuk <alexm@maps.me>
Date: Mon, 11 Apr 2016 18:56:06 +0300
Subject: [PATCH] [new downloader][android] fix: Check free space before
 downloading maps.

---
 .../jni/com/mapswithme/maps/MapManager.cpp    | 15 ++++
 .../maps/downloader/BottomPanel.java          | 39 +++++++----
 .../maps/downloader/DownloaderAdapter.java    | 48 ++++++++-----
 .../maps/downloader/MapManager.java           | 69 ++++++++++++++++++-
 .../maps/downloader/MigrationFragment.java    |  2 +-
 .../maps/downloader/OnmapDownloader.java      |  5 +-
 .../maps/routing/RoutingController.java       | 11 ++-
 storage/storage_helpers.cpp                   | 17 +++--
 storage/storage_helpers.hpp                   |  3 +-
 9 files changed, 165 insertions(+), 44 deletions(-)

diff --git a/android/jni/com/mapswithme/maps/MapManager.cpp b/android/jni/com/mapswithme/maps/MapManager.cpp
index 824fd9e196..bdbc805764 100644
--- a/android/jni/com/mapswithme/maps/MapManager.cpp
+++ b/android/jni/com/mapswithme/maps/MapManager.cpp
@@ -5,6 +5,7 @@
 #include "coding/internal/file_data.hpp"
 
 #include "storage/storage.hpp"
+#include "storage/storage_helpers.hpp"
 
 #include "base/thread_checker.hpp"
 
@@ -96,6 +97,20 @@ Java_com_mapswithme_maps_downloader_MapManager_nativeHasSpaceForMigration(JNIEnv
   return g_framework->HasSpaceForMigration();
 }
 
+// static boolean nativeHasSpaceToDownloadAmount(String root);
+JNIEXPORT jboolean JNICALL
+Java_com_mapswithme_maps_downloader_MapManager_nativeHasSpaceToDownloadAmount(JNIEnv * env, jclass clazz, jlong size)
+{
+  return IsEnoughSpaceForDownload(size);
+}
+
+// static boolean nativeHasSpaceForDownloadCountry(long size);
+JNIEXPORT jboolean JNICALL
+Java_com_mapswithme_maps_downloader_MapManager_nativeHasSpaceToDownloadCountry(JNIEnv * env, jclass clazz, jstring root)
+{
+  return IsEnoughSpaceForDownload(jni::ToNativeString(env, root), GetStorage());
+}
+
 // static native boolean nativeIsLegacyMode();
 JNIEXPORT jboolean JNICALL
 Java_com_mapswithme_maps_downloader_MapManager_nativeIsLegacyMode(JNIEnv * env, jclass clazz)
diff --git a/android/src/com/mapswithme/maps/downloader/BottomPanel.java b/android/src/com/mapswithme/maps/downloader/BottomPanel.java
index bb2c2bd7d2..76f4b66cac 100644
--- a/android/src/com/mapswithme/maps/downloader/BottomPanel.java
+++ b/android/src/com/mapswithme/maps/downloader/BottomPanel.java
@@ -23,13 +23,18 @@ class BottomPanel
     @Override
     public void onClick(View v)
     {
-      MapManager.nativeDownload(mFragment.getAdapter().getCurrentParent());
-
-      Statistics.INSTANCE.trackEvent(Statistics.EventName.DOWNLOADER_ACTION,
-                                     Statistics.params().add(Statistics.EventParam.ACTION, "download")
-                                                        .add(Statistics.EventParam.FROM, "downloader")
-                                                        .add("is_auto", "false")
-                                                        .add("scenario", "download_group"));
+      MapManager.warn3gAndDownload(mFragment.getActivity(), mFragment.getAdapter().getCurrentParent(), new Runnable()
+      {
+        @Override
+        public void run()
+        {
+          Statistics.INSTANCE.trackEvent(Statistics.EventName.DOWNLOADER_ACTION,
+                                         Statistics.params().add(Statistics.EventParam.ACTION, "download")
+                                                            .add(Statistics.EventParam.FROM, "downloader")
+                                                            .add("is_auto", "false")
+                                                            .add("scenario", "download_group"));
+        }
+      });
     }
   };
 
@@ -38,13 +43,21 @@ class BottomPanel
     @Override
     public void onClick(View v)
     {
-      MapManager.nativeUpdate(mFragment.getAdapter().getCurrentParent());
+      final String country = mFragment.getAdapter().getCurrentParent();
+      MapManager.warnOn3g(mFragment.getActivity(), country, new Runnable()
+      {
+        @Override
+        public void run()
+        {
+          MapManager.nativeUpdate(country);
 
-      Statistics.INSTANCE.trackEvent(Statistics.EventName.DOWNLOADER_ACTION,
-                                     Statistics.params().add(Statistics.EventParam.ACTION, "update")
-                                                        .add(Statistics.EventParam.FROM, "downloader")
-                                                        .add("is_auto", "false")
-                                                        .add("scenario", "update_all"));
+          Statistics.INSTANCE.trackEvent(Statistics.EventName.DOWNLOADER_ACTION,
+                                         Statistics.params().add(Statistics.EventParam.ACTION, "update")
+                                                            .add(Statistics.EventParam.FROM, "downloader")
+                                                            .add("is_auto", "false")
+                                                            .add("scenario", "update_all"));
+        }
+      });
     }
   };
 
diff --git a/android/src/com/mapswithme/maps/downloader/DownloaderAdapter.java b/android/src/com/mapswithme/maps/downloader/DownloaderAdapter.java
index 1d159a2352..f077b3545a 100644
--- a/android/src/com/mapswithme/maps/downloader/DownloaderAdapter.java
+++ b/android/src/com/mapswithme/maps/downloader/DownloaderAdapter.java
@@ -174,19 +174,28 @@ class DownloaderAdapter extends RecyclerView.Adapter<DownloaderAdapter.ViewHolde
     UPDATE(R.drawable.ic_update, R.string.downloader_update_map)
     {
       @Override
-      void invoke(CountryItem item, DownloaderAdapter adapter)
+      void invoke(final CountryItem item, DownloaderAdapter adapter)
       {
         item.update();
 
-        if (item.status == CountryItem.STATUS_UPDATABLE)
-          MapManager.nativeUpdate(item.id);
+        if (item.status != CountryItem.STATUS_UPDATABLE)
+          return;
 
-        Statistics.INSTANCE.trackEvent(Statistics.EventName.DOWNLOADER_ACTION,
-                                       Statistics.params().add(Statistics.EventParam.ACTION, "update")
-                                                          .add(Statistics.EventParam.FROM, "downloader")
-                                                          .add("is_auto", "false")
-                                                          .add("scenario", (item.isExpandable() ? "update_group"
-                                                                                                : "update")));
+        MapManager.warnOn3g(adapter.mActivity, item.id, new Runnable()
+        {
+          @Override
+          public void run()
+          {
+            MapManager.nativeUpdate(item.id);
+
+            Statistics.INSTANCE.trackEvent(Statistics.EventName.DOWNLOADER_ACTION,
+                                           Statistics.params().add(Statistics.EventParam.ACTION, "update")
+                                                              .add(Statistics.EventParam.FROM, "downloader")
+                                                              .add("is_auto", "false")
+                                                              .add("scenario", (item.isExpandable() ? "update_group"
+                                                                                                    : "update")));
+          }
+        });
       }
     };
 
@@ -313,14 +322,21 @@ class DownloaderAdapter extends RecyclerView.Adapter<DownloaderAdapter.ViewHolde
         break;
 
       case CountryItem.STATUS_UPDATABLE:
-        MapManager.nativeUpdate(mItem.id);
+        MapManager.warnOn3g(mActivity, mItem.id, new Runnable()
+        {
+          @Override
+          public void run()
+          {
+            MapManager.nativeUpdate(mItem.id);
 
-        Statistics.INSTANCE.trackEvent(Statistics.EventName.DOWNLOADER_ACTION,
-                                       Statistics.params().add(Statistics.EventParam.ACTION, "update")
-                                                          .add(Statistics.EventParam.FROM, "downloader")
-                                                          .add("is_auto", "false")
-                                                          .add("scenario", (mItem.isExpandable() ? "update_group"
-                                                                                                 : "update")));
+            Statistics.INSTANCE.trackEvent(Statistics.EventName.DOWNLOADER_ACTION,
+                                           Statistics.params().add(Statistics.EventParam.ACTION, "update")
+                                                              .add(Statistics.EventParam.FROM, "downloader")
+                                                              .add("is_auto", "false")
+                                                              .add("scenario", (mItem.isExpandable() ? "update_group"
+                                                                                                     : "update")));
+          }
+        });
         break;
 
       default:
diff --git a/android/src/com/mapswithme/maps/downloader/MapManager.java b/android/src/com/mapswithme/maps/downloader/MapManager.java
index be831d8386..f1b5f0c2fb 100644
--- a/android/src/com/mapswithme/maps/downloader/MapManager.java
+++ b/android/src/com/mapswithme/maps/downloader/MapManager.java
@@ -150,7 +150,40 @@ public final class MapManager
     Framework.nativeUpdateSavedDataVersion();
   }
 
-  public static boolean warnDownloadOn3g(Activity activity, @NonNull final Runnable onAcceptListener)
+  private static void notifyNoSpaceInternal(Activity activity)
+  {
+    new AlertDialog.Builder(activity)
+        .setTitle(R.string.downloader_no_space_title)
+        .setMessage(R.string.downloader_no_space_message)
+        .setPositiveButton(android.R.string.ok, null)
+        .show();
+  }
+
+  /**
+   * @return true if there is no space to download the given {@code root}, so the alert dialog will be shown.
+   */
+  public static boolean notifyNoSpace(Activity activity, String root)
+  {
+    if (nativeHasSpaceToDownloadCountry(root))
+      return false;
+
+    notifyNoSpaceInternal(activity);
+    return true;
+  }
+
+  /**
+   * @return true if there is no space to download {@code size} bytes, so the alert dialog will be shown.
+   */
+  public static boolean notifyNoSpace(Activity activity, long size)
+  {
+    if (nativeHasSpaceToDownloadAmount(size))
+      return false;
+
+    notifyNoSpaceInternal(activity);
+    return true;
+  }
+
+  private static boolean warnOn3gInternal(Activity activity, @NonNull final Runnable onAcceptListener)
   {
     if (sSkip3gCheck || !ConnectionState.isMobileConnected())
     {
@@ -175,9 +208,29 @@ public final class MapManager
     return true;
   }
 
+  public static boolean warnOn3g(Activity activity, @Nullable String countryId, @NonNull final Runnable onAcceptListener)
+  {
+    //noinspection SimplifiableIfStatement
+    if (TextUtils.isEmpty(countryId) || !notifyNoSpace(activity, countryId))
+      return warnOn3gInternal(activity, onAcceptListener);
+
+    return true;
+  }
+
+  public static boolean warnOn3g(Activity activity, long size, @NonNull final Runnable onAcceptListener)
+  {
+    if (!notifyNoSpace(activity, size))
+    {
+      onAcceptListener.run();
+      return false;
+    }
+
+    return warnOn3gInternal(activity, onAcceptListener);
+  }
+
   public static boolean warn3gAndDownload(Activity activity, final String countryId, @Nullable final Runnable onAcceptListener)
   {
-    return warnDownloadOn3g(activity, new Runnable()
+    return warnOn3g(activity, countryId, new Runnable()
     {
       @Override
       public void run()
@@ -191,7 +244,7 @@ public final class MapManager
 
   public static boolean warn3gAndRetry(Activity activity, final String countryId, @Nullable final Runnable onAcceptListener)
   {
-    return warnDownloadOn3g(activity, new Runnable()
+    return warnOn3g(activity, countryId, new Runnable()
     {
       @Override
       public void run()
@@ -218,6 +271,16 @@ public final class MapManager
    */
   public static native boolean nativeHasSpaceForMigration();
 
+  /**
+   * Returns {@code true} if there is enough storage space to download specified amount of data. Or {@code false} otherwise.
+   */
+  public static native boolean nativeHasSpaceToDownloadAmount(long size);
+
+  /**
+   * Returns {@code true} if there is enough storage space to download maps with specified {@code root}. Or {@code false} otherwise.
+   */
+  public static native boolean nativeHasSpaceToDownloadCountry(String root);
+
   /**
    * Determines whether the legacy (large MWMs) mode is used.
    */
diff --git a/android/src/com/mapswithme/maps/downloader/MigrationFragment.java b/android/src/com/mapswithme/maps/downloader/MigrationFragment.java
index b85a4c8ec8..7e772683f8 100644
--- a/android/src/com/mapswithme/maps/downloader/MigrationFragment.java
+++ b/android/src/com/mapswithme/maps/downloader/MigrationFragment.java
@@ -37,7 +37,7 @@ public class MigrationFragment extends BaseMwmFragment
     @Override
     public void onClick(final View v)
     {
-      MapManager.warnDownloadOn3g(getActivity(), new Runnable()
+      MapManager.warnOn3g(getActivity(), null, new Runnable()
       {
         @Override
         public void run()
diff --git a/android/src/com/mapswithme/maps/downloader/OnmapDownloader.java b/android/src/com/mapswithme/maps/downloader/OnmapDownloader.java
index bdc694c7fe..b07fa46977 100644
--- a/android/src/com/mapswithme/maps/downloader/OnmapDownloader.java
+++ b/android/src/com/mapswithme/maps/downloader/OnmapDownloader.java
@@ -140,7 +140,8 @@ public class OnmapDownloader implements MwmActivity.LeftAnimationTrackListener
               if (loc != null)
               {
                 String country = MapManager.nativeFindCountry(loc.getLatitude(), loc.getLongitude());
-                if (TextUtils.equals(mCurrentCountry.id, country))
+                if (TextUtils.equals(mCurrentCountry.id, country) &&
+                    MapManager.nativeHasSpaceToDownloadCountry(country))
                 {
                   MapManager.nativeDownload(mCurrentCountry.id);
 
@@ -200,7 +201,7 @@ public class OnmapDownloader implements MwmActivity.LeftAnimationTrackListener
           return;
         }
 
-        MapManager.warnDownloadOn3g(mActivity, new Runnable()
+        MapManager.warnOn3g(mActivity, mCurrentCountry.id, new Runnable()
         {
           @Override
           public void run()
diff --git a/android/src/com/mapswithme/maps/routing/RoutingController.java b/android/src/com/mapswithme/maps/routing/RoutingController.java
index ca5e325295..19226c5ae9 100644
--- a/android/src/com/mapswithme/maps/routing/RoutingController.java
+++ b/android/src/com/mapswithme/maps/routing/RoutingController.java
@@ -21,6 +21,7 @@ import com.mapswithme.maps.Framework;
 import com.mapswithme.maps.MwmApplication;
 import com.mapswithme.maps.R;
 import com.mapswithme.maps.bookmarks.data.MapObject;
+import com.mapswithme.maps.downloader.CountryItem;
 import com.mapswithme.maps.downloader.MapManager;
 import com.mapswithme.maps.location.LocationHelper;
 import com.mapswithme.util.Config;
@@ -166,7 +167,15 @@ public class RoutingController
       @Override
       public boolean onDownload()
       {
-        return !MapManager.warnDownloadOn3g(mContainer.getActivity(), new Runnable()
+        long size = 0;
+        for (String map : mLastMissingMaps)
+        {
+          CountryItem country = CountryItem.fill(map);
+          if (country.status != CountryItem.STATUS_PROGRESS)
+            size += (country.totalSize - country.size);
+        }
+
+        return !MapManager.warnOn3g(mContainer.getActivity(), size, new Runnable()
         {
           @Override
           public void run()
diff --git a/storage/storage_helpers.cpp b/storage/storage_helpers.cpp
index 4c632c5f35..48cc8e723c 100644
--- a/storage/storage_helpers.cpp
+++ b/storage/storage_helpers.cpp
@@ -20,17 +20,20 @@ bool IsDownloadFailed(Status status)
          status == Status::EUnknown;
 }
 
+bool IsEnoughSpaceForDownload(TMwmSize size)
+{
+  // Mwm size is less than kMaxMwmSizeBytes. In case of map update at first we download updated map
+  // and only after that we do delete the obsolete map. So in such a case we might need up to
+  // kMaxMwmSizeBytes of extra space.
+  return GetPlatform().GetWritableStorageStatus(size + kMaxMwmSizeBytes) ==
+         Platform::TStorageStatus::STORAGE_OK;
+}
+
 bool IsEnoughSpaceForDownload(TCountryId const & countryId, Storage const & storage)
 {
   NodeAttrs nodeAttrs;
   storage.GetNodeAttrs(countryId, nodeAttrs);
-  // Mwm size is less than kMaxMwmSizeBytes. In case of map update at first we download updated map
-  // and only after that we do delete the obsolete map. So in such a case we might need up to
-  // kMaxMwmSizeBytes of extra space.
-  size_t const downloadSpaceSize =
-      kMaxMwmSizeBytes + nodeAttrs.m_mwmSize - nodeAttrs.m_localMwmSize;
-  return GetPlatform().GetWritableStorageStatus(downloadSpaceSize) ==
-         Platform::TStorageStatus::STORAGE_OK;
+  return IsEnoughSpaceForDownload(nodeAttrs.m_mwmSize - nodeAttrs.m_localMwmSize);
 }
 
 m2::RectD CalcLimitRect(TCountryId const & countryId,
diff --git a/storage/storage_helpers.hpp b/storage/storage_helpers.hpp
index c849be21c2..37e8ac33d1 100644
--- a/storage/storage_helpers.hpp
+++ b/storage/storage_helpers.hpp
@@ -11,7 +11,7 @@ namespace storage
 class CountryInfoGetter;
 class Storage;
 
-size_t constexpr kMaxMwmSizeBytes = 100 /*Mb*/ * 1024 * 1024;
+TMwmSize constexpr kMaxMwmSizeBytes = 100 /*Mb*/ * 1024 * 1024;
 
 /// \returns true if |position| is covered by a downloaded mwms and false otherwise.
 /// \note |position| has coordinates in mercator.
@@ -22,6 +22,7 @@ bool IsPointCoveredByDownloadedMaps(m2::PointD const & position,
 
 bool IsDownloadFailed(Status status);
 
+bool IsEnoughSpaceForDownload(TMwmSize size);
 bool IsEnoughSpaceForDownload(TCountryId const & countryId, Storage const & storage);
 
 /// \brief Calculates limit rect for |countryId| (expandable or not).