From fd3fbfce5ad176e7bc861d7644fc3207582f63ff Mon Sep 17 00:00:00 2001 From: vng Date: Fri, 27 Mar 2015 13:54:12 +0300 Subject: [PATCH] =?UTF-8?q?Removed=20reserve(N+1)=20in=20buffer=5Fvector.?= =?UTF-8?q?=20It=E2=80=99s=20a=20stupid=20logic=20when=20we=20have=20a=20s?= =?UTF-8?q?equence=20of=20push=5Fback=20or=20emplace=5Fback=20calls.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- base/base_tests/buffer_vector_test.cpp | 3 --- base/buffer_vector.hpp | 2 -- 2 files changed, 5 deletions(-) diff --git a/base/base_tests/buffer_vector_test.cpp b/base/base_tests/buffer_vector_test.cpp index 3a209197f4..cf1407f203 100644 --- a/base/base_tests/buffer_vector_test.cpp +++ b/base/base_tests/buffer_vector_test.cpp @@ -74,12 +74,9 @@ UNIT_TEST(BufferVectorSwap) TEST_EQUAL ( v1[0][0], 666, () ); TEST_EQUAL ( dd1, v1[0].data(), () ); - // resize from 1 to 7 => will push_back v[0] to new place - // (??? but can stay at the same place ???) v1.resize(7); TEST_EQUAL ( v1[0].size(), 1, () ); TEST_EQUAL ( v1[0][0], 666, () ); - TEST_NOT_EQUAL ( dd1, v1[0].data(), () ); } { diff --git a/base/buffer_vector.hpp b/base/buffer_vector.hpp index 31fd71bb7f..d33cb825df 100644 --- a/base/buffer_vector.hpp +++ b/base/buffer_vector.hpp @@ -278,7 +278,6 @@ public: else { ASSERT_EQUAL(m_size, N, ()); - m_dynamic.reserve(N + 1); SwitchToDynamic(); m_dynamic.push_back(t); ASSERT_EQUAL(m_dynamic.size(), N + 1, ()); @@ -297,7 +296,6 @@ public: else { ASSERT_EQUAL(m_size, N, ()); - m_dynamic.reserve(N + 1); SwitchToDynamic(); m_dynamic.push_back(move(t)); ASSERT_EQUAL(m_dynamic.size(), N + 1, ());