From 01859c66cfe3560f25f25a8fae7aeb971bd0563a Mon Sep 17 00:00:00 2001 From: Kiryl Kaveryn Date: Fri, 15 Mar 2024 20:29:55 +0400 Subject: [PATCH] [bookmarks] refactor `UpdateBmGroupIdList` method Signed-off-by: Kiryl Kaveryn --- map/bookmark_manager.cpp | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/map/bookmark_manager.cpp b/map/bookmark_manager.cpp index 8c0c77d55f..cace139b4d 100644 --- a/map/bookmark_manager.cpp +++ b/map/bookmark_manager.cpp @@ -2207,16 +2207,11 @@ void BookmarkManager::UpdateBmGroupIdList() CHECK_THREAD_CHECKER(m_threadChecker, ()); size_t const count = m_categories.size(); - using PairT = std::pair; - std::vector vec; - vec.reserve(count); - for (auto const & [markGroupId, categoryPtr] : m_categories) - vec.emplace_back(markGroupId, categoryPtr.get()); - m_unsortedBmGroupsIdList.clear(); m_unsortedBmGroupsIdList.resize(count); - for (size_t i = 0; i < count; ++i) - m_unsortedBmGroupsIdList[i] = vec[i].first; + size_t i {0}; + for (auto const & [markGroupId, _] : m_categories) + m_unsortedBmGroupsIdList[i++] = markGroupId; } std::vector BookmarkManager::GetSortedBmGroupIdList() const