From 2ab095ea2ad7ce59a9acbceee2240fb95c87ce74 Mon Sep 17 00:00:00 2001 From: Ilya Grechuhin Date: Thu, 28 Jan 2016 17:37:45 +0300 Subject: [PATCH] [ios] Added edit & authorization logging to statistics. --- .../Login/MWMAuthorizationLoginViewController.mm | 13 +++++++++++-- .../Maps/Classes/Editor/MWMEditorViewController.mm | 2 ++ iphone/Maps/Mapsme.storyboard | 3 ++- iphone/Maps/Statistics/StatisticsStrings.h | 6 ++++++ 4 files changed, 21 insertions(+), 3 deletions(-) diff --git a/iphone/Maps/Classes/CustomViews/Login/MWMAuthorizationLoginViewController.mm b/iphone/Maps/Classes/CustomViews/Login/MWMAuthorizationLoginViewController.mm index cade59ea83..980fa42724 100644 --- a/iphone/Maps/Classes/CustomViews/Login/MWMAuthorizationLoginViewController.mm +++ b/iphone/Maps/Classes/CustomViews/Login/MWMAuthorizationLoginViewController.mm @@ -4,6 +4,7 @@ #import "MWMAuthorizationCommon.h" #import "MWMAuthorizationLoginViewController.h" #import "MWMAuthorizationWebViewLoginViewController.h" +#import "Statistics.h" #import "UIColor+MapsMeColor.h" #include "editor/osm_auth.hpp" @@ -45,6 +46,7 @@ using namespace osm; - (void)viewDidLoad { + [[Statistics instance] logEvent:kStatEventName(kStatAuthorization, kStatOpen)]; [super viewDidLoad]; self.backgroundImage.image = [UIImage imageWithColor:[UIColor primary]]; [self checkConnection]; @@ -191,16 +193,22 @@ using namespace osm; - (IBAction)loginGoogle { - // TODO: Add login + [[Statistics instance] logEvent:kStatEventName(kStatAuthorization, kStatGoogle)]; } - (IBAction)loginFacebook { - // TODO: Add login + [[Statistics instance] logEvent:kStatEventName(kStatAuthorization, kStatFacebook)]; +} + +- (IBAction)loginOSM +{ + [[Statistics instance] logEvent:kStatEventName(kStatAuthorization, kStatOSM)]; } - (IBAction)signup { + [[Statistics instance] logEvent:kStatEventName(kStatAuthorization, kStatSignup)]; OsmOAuth const auth = OsmOAuth::ServerAuth(); NSURL * url = [NSURL URLWithString:@(auth.GetRegistrationURL().c_str())]; [[UIApplication sharedApplication] openURL:url]; @@ -208,6 +216,7 @@ using namespace osm; - (IBAction)logout { + [[Statistics instance] logEvent:kStatEventName(kStatAuthorization, kStatLogout)]; MWMAuthorizationStoreCredentials({}); [self cancel]; } diff --git a/iphone/Maps/Classes/Editor/MWMEditorViewController.mm b/iphone/Maps/Classes/Editor/MWMEditorViewController.mm index 547c37a328..aae2620f8e 100644 --- a/iphone/Maps/Classes/Editor/MWMEditorViewController.mm +++ b/iphone/Maps/Classes/Editor/MWMEditorViewController.mm @@ -88,6 +88,7 @@ NSString * reuseIdentifier(MWMPlacePageCellType cellType) - (void)viewDidLoad { + [[Statistics instance] logEvent:kStatEventName(kStatEdit, kStatOpen)]; [super viewDidLoad]; [self configTable]; [self configNavBar]; @@ -167,6 +168,7 @@ NSString * reuseIdentifier(MWMPlacePageCellType cellType) { if (!m_edited_cells.empty()) { + [[Statistics instance] logEvent:kStatEventName(kStatEdit, kStatSave)]; MWMAuthorizationSetNeedCheck(YES); self.entity.cuisines = self.cuisines; [self.entity saveEditedCells:m_edited_cells]; diff --git a/iphone/Maps/Mapsme.storyboard b/iphone/Maps/Mapsme.storyboard index 5cee787888..e69e4ad229 100644 --- a/iphone/Maps/Mapsme.storyboard +++ b/iphone/Maps/Mapsme.storyboard @@ -1,5 +1,5 @@ - + @@ -1871,6 +1871,7 @@ the world. Join us! + diff --git a/iphone/Maps/Statistics/StatisticsStrings.h b/iphone/Maps/Statistics/StatisticsStrings.h index d522e9ee79..52d398c638 100644 --- a/iphone/Maps/Statistics/StatisticsStrings.h +++ b/iphone/Maps/Statistics/StatisticsStrings.h @@ -54,8 +54,10 @@ static NSString * const kStatExpand = @"Expand"; static NSString * const kStatExpandCategory = @"Expand category"; static NSString * const kStatExpandLargeCountry = @"Expand large country"; static NSString * const kStatExport = @"Export"; +static NSString * const kStatFacebook = @"Facebook"; static NSString * const kStatFromMyPosition = @"From my position"; static NSString * const kStatGo = @"Go"; +static NSString * const kStatGoogle = @"Google"; static NSString * const kStatHelp = @"Help"; static NSString * const kStatHidden = @"Hidden"; static NSString * const kStatHistory = @"History"; @@ -66,6 +68,7 @@ static NSString * const kStatKilometers = @"Kilometers"; static NSString * const kStatLandscape = @"Landscape"; static NSString * const kStatLanguage = @"Language"; static NSString * const kStatLocation = @"Location"; +static NSString * const kStatLogout = @"Logout"; static NSString * const kStatMap = @"Map search"; static NSString * const kStatMapViewStyle = @"Map view style"; static NSString * const kStatMapViewStyleSettings = @"Map view style settings"; @@ -86,6 +89,7 @@ static NSString * const kStatOpen = @"Open"; static NSString * const kStatOpenActionSheet = @"Open action sheet"; static NSString * const kStatOpenSite = @"Open site"; static NSString * const kStatOrientation = @"Orientation"; +static NSString * const kStatOSM = @"OSM"; static NSString * const kStatOther = @"Other"; static NSString * const kStatOut = @"Out"; static NSString * const kStatPedestrian = @"Pedestrian"; @@ -100,6 +104,7 @@ static NSString * const kStatRegular = @"Regular"; static NSString * const kStatRemove = @"Remove"; static NSString * const kStatRename = @"Rename"; static NSString * const kStatReport = @"Report"; +static NSString * const kStatSave = @"Save"; static NSString * const kStatScreen = @"Screen"; static NSString * const kStatSearch = @"Search"; static NSString * const kStatSearchEnteredState = @"Search entered state"; @@ -112,6 +117,7 @@ static NSString * const kStatSettingsOpenSection = @"Settings open section"; static NSString * const kStatShare = @"Share"; static NSString * const kStatShowBig2SmallMWM = @"Big mwms to small mwms dialog appearing counter"; static NSString * const kStatShowOnMap = @"Show on map"; +static NSString * const kStatSignup = @"Signup"; static NSString * const kStatSocial = @"Social"; static NSString * const kStatSource = @"Source"; static NSString * const kStatStart = @"Start";