gpesquero/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com>
Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
This commit is contained in:
Sergiy Kozyr 2024-08-20 09:39:35 +03:00 • committed by GitHub
parent db1552c1bf
commit 6371fe09ef
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
android/app/src/main/cpp/app/organicmaps/Framework.cpp
View file

@ -865,8 +865,8 @@ Java_app_organicmaps_Framework_nativeGetParsedAppName(JNIEnv * env, jclass)
JNIEXPORT jstring JNICALL
Java_app_organicmaps_Framework_nativeGetParsedOAuth2Code(JNIEnv * env, jclass)
{
std::string const & code = frm()->GetParsedOAuth2Code();
return jni::ToJavaString(env, code);
std::string const & code = frm()->GetParsedOAuth2Code();
return jni::ToJavaString(env, code);
}
JNIEXPORT jstring JNICALL

4
android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
View file

@ -37,8 +37,8 @@ extern "C"
JNIEXPORT jstring JNICALL
Java_app_organicmaps_editor_OsmOAuth_nativeGetOAuth2Url(JNIEnv * env, jclass)
{
auto const auth = OsmOAuth::ServerAuth();
return ToJavaString(env, auth.BuildOAuth2Url());
auto const auth = OsmOAuth::ServerAuth();
return ToJavaString(env, auth.BuildOAuth2Url());
}
JNIEXPORT jstring JNICALL

3
android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
View file

@ -24,7 +24,8 @@ import app.organicmaps.util.Utils;
import app.organicmaps.util.concurrency.ThreadPool;
import app.organicmaps.util.concurrency.UiThread;
public class OsmLoginBottomFragment extends BottomSheetDialogFragment {
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{
final private OsmLoginFragment parentFragment;
private TextInputEditText mLoginInput;
private TextInputEditText mPasswordInput;

2
editor/osm_auth.cpp
View file

@ -282,7 +282,7 @@ string OsmOAuth::BuildOAuth2Url() const
{"scope", m_oauth2params.m_scope},
{"response_type", "code"}
});
return requestTokenUrl + "?" + requestTokenQuery;
return requestTokenUrl.append('?').append(requestTokenQuery);
}
string OsmOAuth::FinishAuthorization(string const & oauth2code) const