From 6e58697a8b4ea98fa841b43d28c9163612ec0bda Mon Sep 17 00:00:00 2001 From: Ilya Grechuhin Date: Tue, 1 Mar 2016 14:21:07 +0300 Subject: [PATCH] [ios] Updated statistics logging. --- iphone/Maps/Classes/MapViewController.mm | 6 +++--- iphone/Maps/Classes/Migration/MWMMigrationViewController.mm | 6 +++--- iphone/Maps/Statistics/StatisticsStrings.h | 5 +++-- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/iphone/Maps/Classes/MapViewController.mm b/iphone/Maps/Classes/MapViewController.mm index 0ec8b23672..230b555828 100644 --- a/iphone/Maps/Classes/MapViewController.mm +++ b/iphone/Maps/Classes/MapViewController.mm @@ -647,13 +647,13 @@ NSString * const kEditorSegue = @"Map2EditorSegue"; case NodeErrorCode::NoError: break; case NodeErrorCode::UnknownError: - [Statistics logEvent:[NSString stringWithFormat:@"%@%@", kStatDownloaderError, kStatUnknownError]]; + [Statistics logEvent:kStatDownloaderMapError withParameters:@{kStatType : kStatUnknownError}]; break; case NodeErrorCode::OutOfMemFailed: - [Statistics logEvent:[NSString stringWithFormat:@"%@%@", kStatDownloaderError, kStatNotEnoughSpaceError]]; + [Statistics logEvent:kStatDownloaderMapError withParameters:@{kStatType : kStatNotEnoughSpaceError}]; break; case NodeErrorCode::NoInetConnection: - [Statistics logEvent:[NSString stringWithFormat:@"%@%@", kStatDownloaderError, kStatNetworkError]]; + [Statistics logEvent:kStatDownloaderMapError withParameters:@{kStatType : kStatNetworkError}]; break; } } diff --git a/iphone/Maps/Classes/Migration/MWMMigrationViewController.mm b/iphone/Maps/Classes/Migration/MWMMigrationViewController.mm index d14e593423..45adf099df 100644 --- a/iphone/Maps/Classes/Migration/MWMMigrationViewController.mm +++ b/iphone/Maps/Classes/Migration/MWMMigrationViewController.mm @@ -95,15 +95,15 @@ using namespace storage; case NodeErrorCode::NoError: break; case NodeErrorCode::UnknownError: - [Statistics logEvent:[NSString stringWithFormat:@"%@%@", kStatDownloaderError, kStatUnknownError]]; + [Statistics logEvent:kStatDownloaderMigrationError withParameters:@{kStatType : kStatUnknownError}]; [avc presentInternalErrorAlert]; break; case NodeErrorCode::OutOfMemFailed: - [Statistics logEvent:[NSString stringWithFormat:@"%@%@", kStatDownloaderError, kStatNotEnoughSpaceError]]; + [Statistics logEvent:kStatDownloaderMigrationError withParameters:@{kStatType : kStatNotEnoughSpaceError}]; [avc presentDownloaderNotEnoughSpaceAlert]; break; case NodeErrorCode::NoInetConnection: - [Statistics logEvent:[NSString stringWithFormat:@"%@%@", kStatDownloaderError, kStatNetworkError]]; + [Statistics logEvent:kStatDownloaderMigrationError withParameters:@{kStatType : kStatNetworkError}]; [avc presentDownloaderNoConnectionAlertWithOkBlock:^ { [MWMStorage retryDownloadNode:countryId]; diff --git a/iphone/Maps/Statistics/StatisticsStrings.h b/iphone/Maps/Statistics/StatisticsStrings.h index 5a9d69ece8..b14a0d5b18 100644 --- a/iphone/Maps/Statistics/StatisticsStrings.h +++ b/iphone/Maps/Statistics/StatisticsStrings.h @@ -51,10 +51,11 @@ static NSString * const kStatDownload = @"download"; static NSString * const kStatDownloadAll = @"download all"; static NSString * const kStatDownloader = @"downloader"; static NSString * const kStatDownloaderDialog = @"Downloader dialog"; -static NSString * const kStatDownloaderError = @"Downloader_Error_"; static NSString * const kStatDownloaderMapAction = @"Downloader_Map_action"; +static NSString * const kStatDownloaderMapError = @"Downloader_Map_error"; static NSString * const kStatDownloaderMigrationCompleted = @"Downloader_Migration_completed"; static NSString * const kStatDownloaderMigrationDialogue = @"Downloader_Migration_dialogue"; +static NSString * const kStatDownloaderMigrationError = @"Downloader_Migration_error"; static NSString * const kStatDownloaderMigrationStarted = @"Downloader_Migration_started"; static NSString * const kStatDownloadMap = @"Download map"; static NSString * const kStatDownloadMaps = @"Download maps"; @@ -155,7 +156,7 @@ static NSString * const kStatToMyPosition = @"To my position"; static NSString * const kStatTTS = @"TTS"; static NSString * const kStatTTSSettings = @"TTS settings"; static NSString * const kStatType = @"type"; -static NSString * const kStatUnknownError = @"unknown error"; +static NSString * const kStatUnknownError = @"unknown_error"; static NSString * const kStatUpdate = @"update"; static NSString * const kStatUpdateAll = @"update all"; static NSString * const kStatValue = @"Value";