gpesquero/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

Improve error handling for download failures and internet connection checks

Browse source 
Signed-off-by: DevarshVasani <vasanidevarsh@gmail.com>
This commit is contained in:
Devarsh Chintanbhai Vasani 2025-03-09 02:08:56 +05:30
parent 9d7984299b
commit 87ff60e63a
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
android/app/src/main/java/app/organicmaps/downloader/OnmapDownloader.java
View file

@ -53,8 +53,7 @@ public class OnmapDownloader implements MwmActivity.LeftAnimationTrackListener
if (!item.isLeafNode)
continue;
if (mError.getVisibility() == View.VISIBLE)
mError.setVisibility(View.GONE);
mError.setVisibility(View.GONE);
if (item.newStatus == CountryItem.STATUS_FAILED)
MapManager.showError(mActivity, item, null);
@ -176,12 +175,14 @@ public class OnmapDownloader implements MwmActivity.LeftAnimationTrackListener
}
}
if (!ConnectionState.INSTANCE.isConnected() &&
failed)
if (failed)
{
if (!(mError.getVisibility() == View.VISIBLE))
mError.setVisibility(View.VISIBLE);
mError.setText("Downloading failed, please check your internet connection");
mError.setVisibility(View.VISIBLE);
if (!ConnectionState.INSTANCE.isConnected())
mError.setText(mActivity.getString(R.string.common_check_internet_connection_dialog));
else
mError.setText(mActivity.getString(R.string.download_has_failed));
}
mButton.setText(failed ? R.string.downloader_retry
: R.string.download);
@ -220,8 +221,7 @@ public class OnmapDownloader implements MwmActivity.LeftAnimationTrackListener
if (mCurrentCountry == null)
return;
if (mError.getVisibility() == View.VISIBLE)
mError.setVisibility(View.GONE);
mError.setVisibility(View.GONE);
boolean retry = (mCurrentCountry.status == CountryItem.STATUS_FAILED);
if (retry)