From b3d0b031783db1d1ad2a44aabcd7711080863aa4 Mon Sep 17 00:00:00 2001 From: Arnaud Vergnet Date: Sun, 16 Apr 2023 11:31:48 +0200 Subject: [PATCH] [android] move share button in place page Also adds a close button and reworks the direction arrow design Signed-off-by: Arnaud Vergnet --- android/res/drawable-hdpi/ic_close.webp | Bin 180 -> 0 bytes android/res/drawable-mdpi/ic_close.webp | Bin 138 -> 0 bytes android/res/drawable-xhdpi/ic_close.webp | Bin 180 -> 0 bytes android/res/drawable-xxhdpi/ic_close.webp | Bin 208 -> 0 bytes android/res/drawable/ic_close.xml | 5 + android/res/drawable/ic_share.xml | 12 +- android/res/layout/place_page_preview.xml | 277 ++++++++++-------- android/res/values/dimens.xml | 1 + android/res/values/styles.xml | 6 + android/res/values/themes-attrs.xml | 1 + android/res/values/themes-base.xml | 2 + .../placepage/PlacePageButtonFactory.java | 4 - .../widget/placepage/PlacePageButtons.java | 1 - .../widget/placepage/PlacePageController.java | 17 +- .../widget/placepage/PlacePageView.java | 9 + 15 files changed, 183 insertions(+), 152 deletions(-) delete mode 100644 android/res/drawable-hdpi/ic_close.webp delete mode 100644 android/res/drawable-mdpi/ic_close.webp delete mode 100644 android/res/drawable-xhdpi/ic_close.webp delete mode 100644 android/res/drawable-xxhdpi/ic_close.webp create mode 100644 android/res/drawable/ic_close.xml diff --git a/android/res/drawable-hdpi/ic_close.webp b/android/res/drawable-hdpi/ic_close.webp deleted file mode 100644 index eb2fa50ef806c5324b4379470025cc01ba89e449..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 180 zcmV;l089T;Nk&Gj00012MM6+kP&iDW0000l5C8-aXJC+Rq%N=e{s{jX2GX`kxz+oZ z@Eb_mCgoP|U&3#YZRFr7^bt zy3`qf(lm%8xEl-+(f0000l3cvyoXP}U61n3^s^H*5Tf=^br@&Et; diff --git a/android/res/drawable-xhdpi/ic_close.webp b/android/res/drawable-xhdpi/ic_close.webp deleted file mode 100644 index 2d6a47eec0ba778362637bb52aff60f0efd1a11e..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 180 zcmV;l089T;Nk&Gj00012MM6+kP&iDV0000l6aWPfUqB#fv+=6$U*Wt3fuzmGtG<7Q z5lGr>yz2W`7(upe>LnO|EC zI5)TEY>4PT1GkM7EqUpn-_TE}AyXI}%IuTse&Feoa88l=&f~p@N&o^176@(#pec|3 iEGB34HHjZJQSs3kARu5s0D)E$a4uDtfFYHfYy|+tolKtq diff --git a/android/res/drawable-xxhdpi/ic_close.webp b/android/res/drawable-xxhdpi/ic_close.webp deleted file mode 100644 index 102159ee4c9a40445d8fca6b0cb13348ea8259eb..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 208 zcmV;>05AViNk&G<00012MM6+kP&iDx0000lAHW9?N1%{x1n552^Ea4=g0u~oJ+1Ta zpbFA9VD_}mzk?EF+sxl>3Rf7yLlXaQTR_{B6cErh;kLHcyutr&u_kb*Qr^JnQbrr) zXmkWmD@62Pf!j99k&o#a!tsCFyn{k+BBheoeM-^|RBb=i3aTzv=mtL4ZJ-i}ddL9j zAp^n4$4ht#))?q^sTgu^Yy+A8=47BtA^evB;m10thxCvE(nEUogdbY;J~Mx4YSz6_ Kcu$e93?cxr!eQ|M diff --git a/android/res/drawable/ic_close.xml b/android/res/drawable/ic_close.xml new file mode 100644 index 0000000000..70db409b33 --- /dev/null +++ b/android/res/drawable/ic_close.xml @@ -0,0 +1,5 @@ + + + diff --git a/android/res/drawable/ic_share.xml b/android/res/drawable/ic_share.xml index 07381c990b..d0d075a1f7 100644 --- a/android/res/drawable/ic_share.xml +++ b/android/res/drawable/ic_share.xml @@ -1,9 +1,5 @@ - - + + diff --git a/android/res/layout/place_page_preview.xml b/android/res/layout/place_page_preview.xml index 43e627afd5..24a17b3e56 100644 --- a/android/res/layout/place_page_preview.xml +++ b/android/res/layout/place_page_preview.xml @@ -1,145 +1,166 @@ - - - - - - - - - - - - + - - - - + + + + + + + + - - + android:layout_marginEnd="@dimen/margin_half" + android:gravity="end" + android:orientation="vertical"> + + + + + + + + + - - - - - + diff --git a/android/res/values/dimens.xml b/android/res/values/dimens.xml index cb2367285b..92dacd950d 100644 --- a/android/res/values/dimens.xml +++ b/android/res/values/dimens.xml @@ -44,6 +44,7 @@ 320dp 56dp + 36dp 40dp 32dp diff --git a/android/res/values/styles.xml b/android/res/values/styles.xml index c342b940a8..c37c6cb910 100644 --- a/android/res/values/styles.xml +++ b/android/res/values/styles.xml @@ -112,6 +112,12 @@ @dimen/appbar_elevation + + +