From b63f283e7987fc9e229341940d7c54755ff230e4 Mon Sep 17 00:00:00 2001 From: Marcel Kummer Date: Tue, 8 Mar 2022 23:35:56 +0100 Subject: [PATCH] "Wrong" fix for rounded corners on bottom of PlacePage This appears to be fixing the problem on first sight by mimicking what has been done for PlacePageHeaderView. Looking very closely at the HeaderView and the Action Bar it becomes apparent that this isn't correct. As it is now, the HeaderView has rounded corners applied independently of the main PlacePage view. That means the bottom corners of the *HeaderView* are rounded as well. That isn't a big visual issue since there's white on light gray background, however it shows that the rounding is done in a non-ideal way. The same applies to the action bar: The top corners are rounded as well. Instead, both views should be clipped by the main PlacePage view so that corner rounding only happens on the actual outer corners. Making the PlacePage clip its subviews however also breaks (rather: clips) its shadow. I assume creating the shadow from a parent view and then putting all internal views inside one more view that does the rounding and clipping may work out. Signed-off-by: Marcel Kummer --- iphone/Maps/UI/PlacePage/PlacePage.storyboard | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iphone/Maps/UI/PlacePage/PlacePage.storyboard b/iphone/Maps/UI/PlacePage/PlacePage.storyboard index bfff12f7f3..338903d4be 100644 --- a/iphone/Maps/UI/PlacePage/PlacePage.storyboard +++ b/iphone/Maps/UI/PlacePage/PlacePage.storyboard @@ -66,7 +66,7 @@ - +