gpesquero/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

Review fixes.

Browse source
This commit is contained in:
Maxim Pimenov 2018-03-16 20:22:43 +03:00 • committed by Vlad Mihaylenko
parent c6aaf72e4e
commit c259f9b241
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
search/search_quality/assessment_tool/edits.cpp
View file

@ -2,6 +2,8 @@
#include "base/assert.hpp"
using namespace std;
namespace
{
void UpdateNumEdits(Edits::Entry const & entry, Edits::Relevance const & r, size_t & numEdits)
@ -27,7 +29,7 @@ bool Edits::Editor::Set(Relevance relevance)
return m_parent.SetRelevance(m_index, relevance);
}
boost::optional<Edits::Relevance> Edits::Editor::Get() const
boost::optional<Edits::Relevance> const & Edits::Editor::Get() const
{
return m_parent.Get(m_index).m_curr;
}
@ -52,7 +54,7 @@ void Edits::Apply()
});
}
void Edits::Reset(std::vector<boost::optional<Edits::Relevance>> const & relevances)
void Edits::Reset(vector<boost::optional<Edits::Relevance>> const & relevances)
{
WithObserver(Update::MakeAll(), [this, &relevances]() {
m_entries.resize(relevances.size());
@ -147,9 +149,9 @@ Edits::Entry const & Edits::GetEntry(size_t index) const
return m_entries[index];
}
std::vector<boost::optional<Edits::Relevance>> Edits::GetRelevances() const
vector<boost::optional<Edits::Relevance>> Edits::GetRelevances() const
{
std::vector<boost::optional<Edits::Relevance>> relevances(m_entries.size());
vector<boost::optional<Edits::Relevance>> relevances(m_entries.size());
for (size_t i = 0; i < m_entries.size(); ++i)
relevances[i] = m_entries[i].m_curr;
return relevances;

2
search/search_quality/assessment_tool/edits.hpp
View file

@ -73,7 +73,7 @@ public:
// Sets relevance to |relevance|. Returns true iff |relevance|
// differs from the original one.
bool Set(Relevance relevance);
boost::optional<Relevance> Get() const;
boost::optional<Relevance> const & Get() const;
bool HasChanges() const;
Entry::Type GetType() const;