gpesquero/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

Review fixes.

Browse source
This commit is contained in:
vng 2016-03-31 21:06:07 +03:00
parent 9d52efd653
commit f18d1ed152
3 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
map/style_tests/style_symbols_consistency_test.cpp
View file

@ -69,15 +69,15 @@ UNIT_TEST(Test_SymbolsConsistency)
bool res = true;
string densities[] = { "ldpi", "mdpi", "hdpi", "xhdpi", "xxhdpi", "6plus" };
string const densities[] = { "ldpi", "mdpi", "hdpi", "xhdpi", "xxhdpi", "6plus" };
styles::RunForEveryMapStyle([&](MapStyle mapStyle)
{
set<string> const drawingRuleSymbols = GetSymbolsSetFromDrawingRule();
for (string dencity : densities)
for (string const & density : densities)
{
set<string> const resourceStyles = GetSymbolsSetFromResourcesFile(dencity);
set<string> const resourceStyles = GetSymbolsSetFromResourcesFile(density);
vector<string> missed;
set_difference(drawingRuleSymbols.begin(), drawingRuleSymbols.end(),
@ -88,7 +88,7 @@ UNIT_TEST(Test_SymbolsConsistency)
{
// We are interested in all set of bugs, therefore we do not stop test here but
// continue it just keeping in res that test failed.
LOG(LINFO, ("Symbols mismatch: style", mapStyle, ", density", dencity, ", missed", missed));
LOG(LINFO, ("Symbols mismatch: style", mapStyle, ", density", density, ", missed", missed));
res = false;
}
}

2
search/v2/search_model.cpp
View file

@ -26,9 +26,9 @@ TwoLevelPOIChecker::TwoLevelPOIChecker() : ftypes::BaseChecker(2 /* level */)
m_types.push_back(c.GetTypeByPath(arr[i]));
}
/// This checkers should be similar with ftypes::IsAddressObjectChecker, plus public transport.
namespace
{
/// Should be similar with ftypes::IsAddressObjectChecker object classes.
class OneLevelPOIChecker : public ftypes::BaseChecker
{
public:

2
search/v2/search_model.hpp
View file

@ -14,6 +14,8 @@ namespace search
namespace v2
{
/// Describes 2-level POI-exception types that don't belong to any POI-common classes
/// (amenity, shop, tourism, ...). Used in search algo and search categories index generation.
class TwoLevelPOIChecker : public ftypes::BaseChecker
{
public: