gpesquero/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

Speed up strings::to_XXX conversion by removing unnecessary variable check.

Browse source
This commit is contained in:
Alex Zolotarev 2016-03-16 14:11:08 +03:00 • committed by Sergey Yershov
parent 18571c4c96
commit f459cae4c3
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
base/string_utils.cpp
View file

@ -45,7 +45,7 @@ bool to_int(char const * s, int & i, int base /*= 10*/)
{
char * stop;
long const x = strtol(s, &stop, base);
if (stop && *stop == 0)
if (*stop == 0)
{
i = static_cast<int>(x);
ASSERT_EQUAL(static_cast<long>(i), x, ());
@ -62,7 +62,7 @@ bool to_uint64(char const * s, uint64_t & i)
#else
i = strtoull(s, &stop, 10);
#endif
return stop && *stop == 0;
return *stop == 0;
}
bool to_int64(char const * s, int64_t & i)
@ -73,14 +73,14 @@ bool to_int64(char const * s, int64_t & i)
#else
i = strtoll(s, &stop, 10);
#endif
return stop && *stop == 0;
return *stop == 0;
}
bool to_double(char const * s, double & d)
{
char * stop;
d = strtod(s, &stop);
return stop && *stop == 0 && s != stop;
return *stop == 0 && s != stop;
}
UniString MakeLowerCase(UniString const & s)