diff --git a/iphone/Maps/Common/Statistics/StatisticsStrings.h b/iphone/Maps/Common/Statistics/StatisticsStrings.h index 148712e230..251250942c 100644 --- a/iphone/Maps/Common/Statistics/StatisticsStrings.h +++ b/iphone/Maps/Common/Statistics/StatisticsStrings.h @@ -90,7 +90,9 @@ static NSString * const kStatEditorSecondTimeShareClick = @"Editor_SecondTimeSha static NSString * const kStatEditorSecondTimeShareShow = @"Editor_SecondTimeShare_show"; static NSString * const kStatEditTime = @"Edit time"; static NSString * const kStatError = @"Error"; +static NSString * const kStatErrorCode = @"error_code"; static NSString * const kStatErrorData = @"err_data"; +static NSString * const kStatErrorMessage = @"error_message"; static NSString * const kStatExpand = @"Expand"; static NSString * const kStatExpandCategory = @"Expand category"; static NSString * const kStatExpandLargeCountry = @"Expand large country"; @@ -152,7 +154,7 @@ static NSString * const kStatOther = @"Other"; static NSString * const kStatOut = @"Out"; static NSString * const kStatPedestrian = @"Pedestrian"; static NSString * const kStatPlacePage = @"Place page"; -static NSString * const kStatPlacePageBannerEmpty = @"Placepage_Banner_empty"; +static NSString * const kStatPlacePageBannerBlank = @"Placepage_Banner_blank"; static NSString * const kStatPlacePageBannerError = @"Placepage_Banner_error"; static NSString * const kStatPlacePageBannerShow = @"Placepage_Banner_show"; static NSString * const kPlacePageHotelBook = @"Placepage_Hotel_book"; diff --git a/iphone/Maps/UI/PlacePage/MWMPlacePageData.mm b/iphone/Maps/UI/PlacePage/MWMPlacePageData.mm index b3cc99d2dc..9fe9a76c49 100644 --- a/iphone/Maps/UI/PlacePage/MWMPlacePageData.mm +++ b/iphone/Maps/UI/PlacePage/MWMPlacePageData.mm @@ -547,12 +547,24 @@ using namespace place_page; - (void)nativeAd:(FBNativeAd *)nativeAd didFailWithError:(NSError *)error { // https://developers.facebook.com/docs/audience-network/testing - [Statistics logEvent:error.code == 1001 ? kStatPlacePageBannerEmpty : kStatPlacePageBannerError - withParameters:@{ - kStatTags : self.statisticsTags, - kStatBanner : @(m_info.GetBanner().m_bannerId.c_str()), - kStatProvider : kStatFacebook - }]; + NSMutableDictionary * params = [@{kStatTags : self.statisticsTags, + kStatBanner : @(m_info.GetBanner().m_bannerId.c_str()), + kStatProvider : kStatFacebook} mutableCopy]; + + NSString * event; + if (error.code == 1001) + { + event = kStatPlacePageBannerBlank; + } + else + { + event = kStatPlacePageBannerError; + params[kStatErrorCode] = @(error.code); + if (NSString * value = error.userInfo[@"FBAdErrorDetailKey"]) + params[kStatErrorMessage] = value; + } + + [Statistics logEvent:event withParameters:params]; } @end diff --git a/iphone/Maps/UI/PlacePage/MWMPlacePageManager.mm b/iphone/Maps/UI/PlacePage/MWMPlacePageManager.mm index dbafed8724..967fb4500b 100644 --- a/iphone/Maps/UI/PlacePage/MWMPlacePageManager.mm +++ b/iphone/Maps/UI/PlacePage/MWMPlacePageManager.mm @@ -26,7 +26,7 @@ namespace { -void logSponsoredEventEvent(MWMPlacePageData * data, NSString * eventName) +void logSponsoredEvent(MWMPlacePageData * data, NSString * eventName) { auto const & latLon = data.latLon; BOOL const isBooking = data.isBooking; @@ -281,7 +281,7 @@ void logSponsoredEventEvent(MWMPlacePageData * data, NSString * eventName) MWMPlacePageData * data = self.data; BOOL const isBooking = data.isBooking; NSString * eventName = isBooking ? kPlacePageHotelBook : kPlacePageRestaurantBook; - logSponsoredEventEvent(data, eventName); + logSponsoredEvent(data, eventName); UIViewController * vc = static_cast([MapViewController controller]); NSURL * url = isDescription ? data.sponsoredDescriptionURL : data.sponsoredURL; NSAssert(url, @"Sponsored url can't be nil!"); @@ -307,12 +307,13 @@ void logSponsoredEventEvent(MWMPlacePageData * data, NSString * eventName) - (void)showAllReviews { - logSponsoredEventEvent(self.data, kPlacePageHotelReviews); + logSponsoredEvent(self.data, kPlacePageHotelReviews); [[MapViewController controller] openUrl:self.data.URLToAllReviews]; } - (void)showPhotoAtIndex:(NSUInteger)index { + logSponsoredEvent(self.data, kPlacePageHotelGallery); auto model = self.data.photos[index]; auto galleryVc = [MWMGalleryItemViewController instanceWithModel:model]; [[MapViewController controller].navigationController pushViewController:galleryVc animated:YES]; @@ -320,7 +321,7 @@ void logSponsoredEventEvent(MWMPlacePageData * data, NSString * eventName) - (void)showGalery { - logSponsoredEventEvent(self.data, kPlacePageHotelGallery); + logSponsoredEvent(self.data, kPlacePageHotelGallery); auto galleryVc = [MWMGalleryViewController instanceWithModel:[[MWMGalleryModel alloc] initWithTitle:self.hotelName items:self.data.photos]]; [[MapViewController controller].navigationController pushViewController:galleryVc animated:YES]; @@ -328,7 +329,7 @@ void logSponsoredEventEvent(MWMPlacePageData * data, NSString * eventName) - (void)showAllFacilities { - logSponsoredEventEvent(self.data, kPlacePageHotelFacilities); + logSponsoredEvent(self.data, kPlacePageHotelFacilities); [[MapViewController controller] openHotelFacilities]; }