Review fixes.

This commit is contained in:
Yuri Gorshenin 2017-03-10 20:53:19 +03:00 committed by Vladimir Byko-Ianko
parent 193c703eb0
commit e27a6416e1
3 changed files with 5 additions and 7 deletions

View file

@ -20,10 +20,8 @@ void MainModel::Open(std::string const & path)
return;
}
std::string contents;
std::copy(std::istreambuf_iterator<char>(ifs), std::istreambuf_iterator<char>(),
back_inserter(contents));
std::string const contents((std::istreambuf_iterator<char>(ifs)),
(std::istreambuf_iterator<char>()));
std::vector<search::Sample> samples;
if (!search::Sample::DeserializeFromJSON(contents, samples))
{

View file

@ -30,10 +30,10 @@ MainView::MainView(Framework & framework) : m_framework(framework)
void MainView::SetSamples(std::vector<search::Sample> const & samples)
{
m_samplesModel->removeRows(0, m_samplesModel->rowCount());
for (size_t i = 0; i < samples.size(); ++i)
for (auto const & sample : samples)
{
m_samplesModel->appendRow(
new QStandardItem(QString::fromUtf8(strings::ToUtf8(samples[i].m_query).c_str())));
new QStandardItem(QString::fromUtf8(strings::ToUtf8(sample.m_query).c_str())));
}
}

View file

@ -26,7 +26,7 @@ class MainView : public QMainWindow, public View
Q_OBJECT
public:
MainView(Framework & framework);
explicit MainView(Framework & framework);
// View overrides:
void SetSamples(std::vector<search::Sample> const & samples) override;