diff --git a/android/res/drawable-hdpi/ic_bookmark_hide.png b/android/res/drawable-hdpi/ic_bookmark_hide.png deleted file mode 100644 index 514453bc47..0000000000 Binary files a/android/res/drawable-hdpi/ic_bookmark_hide.png and /dev/null differ diff --git a/android/res/drawable-hdpi/ic_bookmark_show.png b/android/res/drawable-hdpi/ic_bookmark_show.png deleted file mode 100644 index afdd01cf9f..0000000000 Binary files a/android/res/drawable-hdpi/ic_bookmark_show.png and /dev/null differ diff --git a/android/res/drawable-mdpi/ic_bookmark_hide.png b/android/res/drawable-mdpi/ic_bookmark_hide.png deleted file mode 100644 index 70efa01700..0000000000 Binary files a/android/res/drawable-mdpi/ic_bookmark_hide.png and /dev/null differ diff --git a/android/res/drawable-mdpi/ic_bookmark_show.png b/android/res/drawable-mdpi/ic_bookmark_show.png deleted file mode 100644 index b1649a2fdd..0000000000 Binary files a/android/res/drawable-mdpi/ic_bookmark_show.png and /dev/null differ diff --git a/android/res/drawable-xhdpi/ic_bookmark_hide.png b/android/res/drawable-xhdpi/ic_bookmark_hide.png deleted file mode 100644 index bcddc30fc5..0000000000 Binary files a/android/res/drawable-xhdpi/ic_bookmark_hide.png and /dev/null differ diff --git a/android/res/drawable-xhdpi/ic_bookmark_show.png b/android/res/drawable-xhdpi/ic_bookmark_show.png deleted file mode 100644 index fc1c970353..0000000000 Binary files a/android/res/drawable-xhdpi/ic_bookmark_show.png and /dev/null differ diff --git a/android/res/drawable-xxhdpi/ic_bookmark_hide.png b/android/res/drawable-xxhdpi/ic_bookmark_hide.png deleted file mode 100644 index 1f51ae3c1a..0000000000 Binary files a/android/res/drawable-xxhdpi/ic_bookmark_hide.png and /dev/null differ diff --git a/android/res/drawable-xxhdpi/ic_bookmark_show.png b/android/res/drawable-xxhdpi/ic_bookmark_show.png deleted file mode 100644 index a7a88fed41..0000000000 Binary files a/android/res/drawable-xxhdpi/ic_bookmark_show.png and /dev/null differ diff --git a/android/res/drawable-xxxhdpi/ic_bookmark_hide.png b/android/res/drawable-xxxhdpi/ic_bookmark_hide.png deleted file mode 100644 index 57520e4218..0000000000 Binary files a/android/res/drawable-xxxhdpi/ic_bookmark_hide.png and /dev/null differ diff --git a/android/res/drawable-xxxhdpi/ic_bookmark_show.png b/android/res/drawable-xxxhdpi/ic_bookmark_show.png deleted file mode 100644 index 1877875519..0000000000 Binary files a/android/res/drawable-xxxhdpi/ic_bookmark_show.png and /dev/null differ diff --git a/android/res/layout/item_bookmark_category.xml b/android/res/layout/item_bookmark_category.xml index 97031e57c9..652e202241 100644 --- a/android/res/layout/item_bookmark_category.xml +++ b/android/res/layout/item_bookmark_category.xml @@ -1,47 +1,62 @@ - - - + - + android:minHeight="@dimen/height_item_edit_bookmark" + android:layout_marginLeft="@dimen/margin_half_plus" + android:layout_marginStart="@dimen/margin_half_plus" + android:layout_marginRight="@dimen/margin_base_plus" + android:layout_marginEnd="@dimen/margin_base_plus"/> - - - + + diff --git a/android/src/com/mapswithme/maps/bookmarks/BookmarkCategoriesAdapter.java b/android/src/com/mapswithme/maps/bookmarks/BookmarkCategoriesAdapter.java index ad5a9246ec..a244515165 100644 --- a/android/src/com/mapswithme/maps/bookmarks/BookmarkCategoriesAdapter.java +++ b/android/src/com/mapswithme/maps/bookmarks/BookmarkCategoriesAdapter.java @@ -115,6 +115,9 @@ public class BookmarkCategoriesAdapter extends BaseBookmarkCategoryAdapter { + Toast.makeText(getContext(), "Coming soon", Toast.LENGTH_SHORT).show(); + }); } @Override diff --git a/android/src/com/mapswithme/maps/bookmarks/Holders.java b/android/src/com/mapswithme/maps/bookmarks/Holders.java index 64f74383c5..3fe4e9b2a1 100644 --- a/android/src/com/mapswithme/maps/bookmarks/Holders.java +++ b/android/src/com/mapswithme/maps/bookmarks/Holders.java @@ -1,16 +1,13 @@ package com.mapswithme.maps.bookmarks; -import android.graphics.drawable.Drawable; import android.support.annotation.NonNull; import android.support.annotation.Nullable; import android.support.v7.widget.RecyclerView; import android.view.View; -import android.widget.ImageView; -import android.widget.SearchView; +import android.widget.CheckBox; import android.widget.TextView; import com.mapswithme.maps.R; -import com.mapswithme.util.Graphics; import com.mapswithme.util.UiUtils; public class Holders @@ -29,34 +26,27 @@ public class Holders @NonNull private final TextView mName; @NonNull - ImageView mVisibilityMarker; + CheckBox mVisibilityMarker; + @NonNull TextView mSize; + @NonNull + View mMore; CategoryViewHolder(@NonNull View root) { super(root); - mName = root.findViewById(R.id.tv__set_name); - mVisibilityMarker = root.findViewById(R.id.iv__set_visible); - mSize = root.findViewById(R.id.tv__set_size); + mName = root.findViewById(R.id.name); + mVisibilityMarker = root.findViewById(R.id.checkbox); + int left = root.getResources().getDimensionPixelOffset(R.dimen.margin_half_plus); + int right = root.getResources().getDimensionPixelOffset(R.dimen.margin_base_plus); + UiUtils.expandTouchAreaForView(mVisibilityMarker, 0, left, 0, right); + mSize = root.findViewById(R.id.size); + mMore = root.findViewById(R.id.more); } void setVisibilityState(boolean visible) { - Drawable drawable; - if (visible) - { - mVisibilityMarker.setBackgroundResource(UiUtils.getStyledResourceId( - mVisibilityMarker.getContext(), R.attr.activeIconBackground)); - drawable = Graphics.tint(mVisibilityMarker.getContext(), R.drawable.ic_bookmark_show, R.attr.activeIconTint); - } - else - { - mVisibilityMarker.setBackgroundResource(UiUtils.getStyledResourceId( - mVisibilityMarker.getContext(), R.attr.steadyIconBackground)); - drawable = Graphics.tint(mVisibilityMarker.getContext(), R.drawable.ic_bookmark_hide, - R.attr.steadyIconTint); - } - mVisibilityMarker.setImageDrawable(drawable); + mVisibilityMarker.setChecked(visible); } void setVisibilityListener(@Nullable View.OnClickListener listener) @@ -64,6 +54,11 @@ public class Holders mVisibilityMarker.setOnClickListener(listener); } + void setMoreListener(@Nullable View.OnClickListener listener) + { + mMore.setOnClickListener(listener); + } + void setName(@NonNull String name) { mName.setText(name); diff --git a/android/src/com/mapswithme/util/UiUtils.java b/android/src/com/mapswithme/util/UiUtils.java index 538449a183..30ffba9477 100644 --- a/android/src/com/mapswithme/util/UiUtils.java +++ b/android/src/com/mapswithme/util/UiUtils.java @@ -484,20 +484,32 @@ public final class UiUtils public static void expandTouchAreaForView(@NonNull final View view, final int extraArea) { final View parent = (View) view.getParent(); - parent.post(new Runnable() - { - @Override - public void run() - { - Rect rect = new Rect(); - view.getHitRect(rect); - rect.top -= extraArea; - rect.left -= extraArea; - rect.right += extraArea; - rect.bottom += extraArea; - parent.setTouchDelegate(new TouchDelegate(rect, view)); - } - }); + parent.post(() -> + { + Rect rect = new Rect(); + view.getHitRect(rect); + rect.top -= extraArea; + rect.left -= extraArea; + rect.right += extraArea; + rect.bottom += extraArea; + parent.setTouchDelegate(new TouchDelegate(rect, view)); + }); + } + + public static void expandTouchAreaForView(@NonNull final View view, final int top, final int left, + final int bottom, final int right) + { + final View parent = (View) view.getParent(); + parent.post(() -> + { + Rect rect = new Rect(); + view.getHitRect(rect); + rect.top -= top; + rect.left -= left; + rect.right += right; + rect.bottom += bottom; + parent.setTouchDelegate(new TouchDelegate(rect, view)); + }); } // utility class