From 38776417938ed26abf2cb67971cc0840916c09fc Mon Sep 17 00:00:00 2001 From: vng Date: Thu, 9 Jul 2015 18:06:54 +0300 Subject: [PATCH] Review fixes. --- generator/osm2type.cpp | 6 +++++- indexer/feature_data.cpp | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/generator/osm2type.cpp b/generator/osm2type.cpp index 7c29fc54fe..6a2878834a 100644 --- a/generator/osm2type.cpp +++ b/generator/osm2type.cpp @@ -237,7 +237,11 @@ namespace ftype if (!m_isKey) { - // Take numbers only for "capital" and "admin_level". + // Take numbers only for "capital" and "admin_level" now. + // NOTE! If you add a new type into classificator, which has a number in it + // (like admin_level=1 or capital=2), please don't forget to insert it here too. + // Otherwise generated data will not contain your newly added features. + if (strings::is_number(v)) return (k == "admin_level" || k == "capital"); } diff --git a/indexer/feature_data.cpp b/indexer/feature_data.cpp index f7e642eaa6..0d9d4fe439 100644 --- a/indexer/feature_data.cpp +++ b/indexer/feature_data.cpp @@ -171,6 +171,7 @@ bool FeatureParams::AddName(string const & lang, string const & s) if (IsDummyName(s)) return false; + // The "default" new name will replace the old one if any (e.g. from AddHouseName call). name.AddString(lang, s); return true; }