From abdb58ba62a3438969d7fecf84ebd2e978bbe75b Mon Sep 17 00:00:00 2001
From: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
Date: Thu, 27 Jun 2024 18:00:45 +0200
Subject: [PATCH] [debug] Add ?all-types debug command to show all internal
 types

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
---
 docs/DEBUG_COMMANDS.md  |  5 +++++
 indexer/map_object.cpp  | 14 ++++++++++++++
 indexer/map_object.hpp  |  3 +++
 map/framework.cpp       | 18 ++++++++++++++++++
 map/framework.hpp       |  2 ++
 map/place_page_info.cpp |  7 +++++++
 map/place_page_info.hpp |  2 ++
 7 files changed, 51 insertions(+)

diff --git a/docs/DEBUG_COMMANDS.md b/docs/DEBUG_COMMANDS.md
index e53aef0235..69a6f492e3 100644
--- a/docs/DEBUG_COMMANDS.md
+++ b/docs/DEBUG_COMMANDS.md
@@ -65,3 +65,8 @@ All the following commands require an app restart:
 ## GPS
 
 - `?gpstrackaccuracy:XXX`: Changes the accuracy of the GPS while recording tracks. Replace `XXX` by the desired horizontal accuracy. Works only on iOS for now.
+
+## Place Page
+
+- `?all-types`: Shows all internal types in place page
+- `?no-all-types`: Disables showing all internal types in place page
diff --git a/indexer/map_object.cpp b/indexer/map_object.cpp
index 04107651ab..05ae0b5016 100644
--- a/indexer/map_object.cpp
+++ b/indexer/map_object.cpp
@@ -136,6 +136,20 @@ std::string MapObject::GetLocalizedAllTypes(bool withMainType) const
   return oss.str();
 }
 
+std::string MapObject::GetAllReadableTypes() const
+{
+  ASSERT(!m_types.Empty(), ());
+  feature::TypesHolder copy(m_types);
+  copy.SortBySpec();
+
+  std::ostringstream oss;
+
+  for (auto const type : copy)
+    oss << classif().GetReadableObjectName(type) << feature::kFieldsSeparator;
+  
+  return oss.str();
+}
+
 std::string_view MapObject::GetMetadata(MetadataID type) const
 {
   return m_metadata.Get(type);
diff --git a/indexer/map_object.hpp b/indexer/map_object.hpp
index 220e0e519c..155652945c 100644
--- a/indexer/map_object.hpp
+++ b/indexer/map_object.hpp
@@ -109,6 +109,9 @@ protected:
   /// @returns "the best" single type to display in UI.
   std::string GetLocalizedType() const;
 
+  /// @returns all readable internal types separated by kFieldsSeparator for debugging.
+  std::string GetAllReadableTypes() const;
+    
   FeatureID m_featureID;
   m2::PointD m_mercator;
 
diff --git a/map/framework.cpp b/map/framework.cpp
index 32fc600c46..09ddd25f3e 100644
--- a/map/framework.cpp
+++ b/map/framework.cpp
@@ -3,6 +3,7 @@
 #include "map/gps_tracker.hpp"
 #include "map/user_mark.hpp"
 #include "map/track_mark.hpp"
+#include "map/place_page_info.hpp"
 
 #include "ge0/url_generator.hpp"
 
@@ -2838,6 +2839,21 @@ bool Framework::ParseRoutingDebugCommand(search::SearchParams const & params)
   return false;
 }
 
+bool Framework::ParseAllTypesDebugCommand(search::SearchParams const & params)
+{
+  if (params.m_query == "?all-types")
+  {
+    settings::Set(place_page::kDebugAllTypesSetting, true);
+    return true;
+  }
+  else if (params.m_query == "?no-all-types")
+  {
+    settings::Set(place_page::kDebugAllTypesSetting, false);
+    return true;
+  }
+  return false;
+}
+
 // Editable map object helper functions.
 namespace
 {
@@ -3239,6 +3255,8 @@ bool Framework::ParseSearchQueryCommand(search::SearchParams const & params)
     return true;
   if (ParseRoutingDebugCommand(params))
     return true;
+  if (ParseAllTypesDebugCommand(params))
+    return true;
   return false;
 }
 
diff --git a/map/framework.hpp b/map/framework.hpp
index c46de8942d..da68948ae9 100644
--- a/map/framework.hpp
+++ b/map/framework.hpp
@@ -607,6 +607,8 @@ private:
 
   /// This function can be used for enabling some experimental features for routing.
   bool ParseRoutingDebugCommand(search::SearchParams const & params);
+    
+  bool ParseAllTypesDebugCommand(search::SearchParams const & params);
 
   void FillFeatureInfo(FeatureID const & fid, place_page::Info & info) const;
   /// @param customTitle, if not empty, overrides any other calculated name.
diff --git a/map/place_page_info.cpp b/map/place_page_info.cpp
index 6da7fe0c0f..88a81253f1 100644
--- a/map/place_page_info.cpp
+++ b/map/place_page_info.cpp
@@ -12,6 +12,7 @@
 #include "platform/utm_mgrs_utils.hpp"
 #include "platform/distance.hpp"
 #include "platform/duration.hpp"
+#include "platform/settings.hpp"
 
 #include "geometry/mercator.hpp"
 
@@ -206,6 +207,12 @@ std::string Info::FormatSubtitle(bool withTypes, bool withMainType) const
   if (!fee.empty())
     append(fee);
 
+  // Debug types
+  bool debugAllTypesSetting = false;
+  settings::TryGet(kDebugAllTypesSetting, debugAllTypesSetting);
+  if (debugAllTypesSetting)
+    append(GetAllReadableTypes());
+
   return result;
 }
 
diff --git a/map/place_page_info.hpp b/map/place_page_info.hpp
index f7539b7fdb..ff16516505 100644
--- a/map/place_page_info.hpp
+++ b/map/place_page_info.hpp
@@ -20,6 +20,8 @@
 
 namespace place_page
 {
+std::string_view constexpr kDebugAllTypesSetting = "DebugAllTypes";
+
 enum class OpeningMode
 {
   Preview = 0,