From f18d1ed152bfaeed29c8604460cc7bf0acd841b6 Mon Sep 17 00:00:00 2001 From: vng Date: Thu, 31 Mar 2016 21:06:07 +0300 Subject: [PATCH] Review fixes. --- map/style_tests/style_symbols_consistency_test.cpp | 8 ++++---- search/v2/search_model.cpp | 2 +- search/v2/search_model.hpp | 2 ++ 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/map/style_tests/style_symbols_consistency_test.cpp b/map/style_tests/style_symbols_consistency_test.cpp index 4324453d14..7ee0c57e3e 100644 --- a/map/style_tests/style_symbols_consistency_test.cpp +++ b/map/style_tests/style_symbols_consistency_test.cpp @@ -69,15 +69,15 @@ UNIT_TEST(Test_SymbolsConsistency) bool res = true; - string densities[] = { "ldpi", "mdpi", "hdpi", "xhdpi", "xxhdpi", "6plus" }; + string const densities[] = { "ldpi", "mdpi", "hdpi", "xhdpi", "xxhdpi", "6plus" }; styles::RunForEveryMapStyle([&](MapStyle mapStyle) { set const drawingRuleSymbols = GetSymbolsSetFromDrawingRule(); - for (string dencity : densities) + for (string const & density : densities) { - set const resourceStyles = GetSymbolsSetFromResourcesFile(dencity); + set const resourceStyles = GetSymbolsSetFromResourcesFile(density); vector missed; set_difference(drawingRuleSymbols.begin(), drawingRuleSymbols.end(), @@ -88,7 +88,7 @@ UNIT_TEST(Test_SymbolsConsistency) { // We are interested in all set of bugs, therefore we do not stop test here but // continue it just keeping in res that test failed. - LOG(LINFO, ("Symbols mismatch: style", mapStyle, ", density", dencity, ", missed", missed)); + LOG(LINFO, ("Symbols mismatch: style", mapStyle, ", density", density, ", missed", missed)); res = false; } } diff --git a/search/v2/search_model.cpp b/search/v2/search_model.cpp index c0c79a35b2..e5c14b9031 100644 --- a/search/v2/search_model.cpp +++ b/search/v2/search_model.cpp @@ -26,9 +26,9 @@ TwoLevelPOIChecker::TwoLevelPOIChecker() : ftypes::BaseChecker(2 /* level */) m_types.push_back(c.GetTypeByPath(arr[i])); } -/// This checkers should be similar with ftypes::IsAddressObjectChecker, plus public transport. namespace { +/// Should be similar with ftypes::IsAddressObjectChecker object classes. class OneLevelPOIChecker : public ftypes::BaseChecker { public: diff --git a/search/v2/search_model.hpp b/search/v2/search_model.hpp index 8ef802f7c3..c9fa6d274e 100644 --- a/search/v2/search_model.hpp +++ b/search/v2/search_model.hpp @@ -14,6 +14,8 @@ namespace search namespace v2 { +/// Describes 2-level POI-exception types that don't belong to any POI-common classes +/// (amenity, shop, tourism, ...). Used in search algo and search categories index generation. class TwoLevelPOIChecker : public ftypes::BaseChecker { public: