organicmaps/fast_double_parser
13
Fork 0
mirror of https://github.com/lemire/fast_double_parser.git synced 2025-04-03 20:04:57 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions

Fixing issue https://github.com/lemire/fast_double_parser/issues/35

Browse source
This commit is contained in:
Daniel Lemire 2020-10-16 12:59:33 -04:00
parent ef3f98f82d
commit 98e746d20c
4 changed files with 3 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/ubuntu18.yml vendored
View file

@ -16,5 +16,5 @@ jobs:
mkdir build &&
cd build &&
cmake .. &&
cmake --build . &&
cmake --build . -DFAST_DOUBLE_BENCHMARKS=ON &&
ctest -j --output-on-failure

2
.github/workflows/ubuntu20.yml vendored
View file

@ -15,6 +15,6 @@ jobs:
run: |
mkdir build &&
cd build &&
cmake .. &&
cmake .. -DFAST_DOUBLE_BENCHMARKS=ON &&
cmake --build . &&
ctest -j --output-on-failure

1
README.md
View file

@ -55,6 +55,7 @@ ctest .
```
Under Windows, the last line should be `./Release/benchmark.exe`.
Be mindful that the benchmarks include the abseil library which is not supported everywhere.
## Sample results

33
benchmarks/benchmark.cpp
View file

@ -34,18 +34,6 @@ double findmax_fast_double_parser(const std::vector<std::string>& s) {
return answer;
}
double findmax_fast_inplace_double_parser(const std::vector<std::string>& s) {
double answer = 0;
double x;
for (const std::string & st : s) {
bool isok = fast_double_parser::parse_number_inplace(st.c_str(), st.c_str() + st.size(), &x);
if (!isok)
throw std::runtime_error("bug in findmax_fast_inplace_double_parser");
answer = answer > x ? answer : x;
}
return answer;
}
double findmax_strtod(const std::vector<std::string>& s) {
double answer = 0;
@ -193,19 +181,6 @@ void validate(const std::vector<std::string>& s) {
printf("f64_ulp_dist = %d\n", (int)f64_ulp_dist(x, xref));
throw std::runtime_error("fast_double_parser disagrees");
}
isok = fast_double_parser::parse_number_inplace(st.c_str(), st.c_str()+st.size(), &x);
if (!isok) {
printf("fast_inplace_double_parser refused to parse %s\n", st.c_str());
throw std::runtime_error("fast_inplace_double_parser refused to parse");
}
if (xref != x) {
std::cerr << "fast_inplace_double_parser disagrees" << std::endl;
printf("fast_inplace_double_parser: %.*e\n", DBL_DIG + 1, x);
printf("reference: %.*e\n", DBL_DIG + 1, xref);
printf("string: %s\n", st.c_str());
printf("f64_ulp_dist = %d\n", (int)f64_ulp_dist(x, xref));
throw std::runtime_error("fast_inplace_double_parser disagrees");
}
}
}
@ -234,14 +209,6 @@ void process(const std::vector<std::string>& lines, size_t volume) {
if (i > 0)
printf("fast_double_parser %.2f MB/s\n", volumeMB * 1000000000 / dif);
t1 = std::chrono::high_resolution_clock::now();
ts = findmax_fast_inplace_double_parser(lines);
t2 = std::chrono::high_resolution_clock::now();
if (ts == 0)
printf("bug\n");
dif = double(std::chrono::duration_cast<std::chrono::nanoseconds>(t2 - t1).count());
if (i > 0)
printf("fast_inplace_double_parser %.2f MB/s\n", volumeMB * 1000000000 / dif);
t1 = std::chrono::high_resolution_clock::now();
ts = findmax_strtod(lines);
t2 = std::chrono::high_resolution_clock::now();
if (ts == 0)