organicmaps/fast_obj
13
Fork 0
mirror of https://github.com/thisistherk/fast_obj.git synced 2025-04-05 05:25:03 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions

Fix negative index parsing

Browse source 
Negative indices refer to offsets of vertices (before multiplying by
stride), but array size of position/etc. is multiplied by stride.

Integer division isn't ideal for performance, however division by 3 is
lowered into integer multiplication on gcc/clang/msvc so this shouldn't
be a big concern.
This commit is contained in:
Arseny Kapoulkine 2019-06-01 12:04:48 -07:00
parent 814900cd31
commit 095a1b0b92
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
fast_obj.h
View file

@ -664,19 +664,19 @@ const char* parse_face(fastObjData* data, const char* ptr)
}
if (v < 0)
vn.p = array_size(data->mesh->positions) - (unsigned int)(-v);
vn.p = (array_size(data->mesh->positions) / 3) - (unsigned int)(-v);
else
vn.p = (unsigned int)(v);
if (t < 0)
vn.t = array_size(data->mesh->texcoords) - (unsigned int)(-t);
vn.t = (array_size(data->mesh->texcoords) / 2) - (unsigned int)(-t);
else if (t > 0)
vn.t = (unsigned int)(t);
else
vn.t = 0;
if (n < 0)
vn.n = array_size(data->mesh->normals) - (unsigned int)(-n);
vn.n = (array_size(data->mesh->normals) / 3) - (unsigned int)(-n);
else if (n > 0)
vn.n = (unsigned int)(n);
else