organicmaps/freetype
13
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity Actions

[apinames] Fix the overflow of signed integer hash.

Browse source 
* src/tools/apinames.c (names_add): Change the type of `h' from
int to unsigned int, to prevent undefined behaviour in the
overflow of signed integers (overflow of unsigned int is defined
to be wrap around).  Found by clang test suggested by Sean
McBride.
This commit is contained in:
suzuki toshiya 2011-11-30 22:40:43 +09:00
parent 628bebe639
commit eba2781ab9
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ChangeLog
View file

@ -1,3 +1,13 @@
2011-11-30 suzuki toshiya <mpsuzuki@hiroshima-u.ac.jp>
[apinames] Fix the overflow of signed integer hash.
* src/tools/apinames.c (names_add): Change the type of `h' from
int to unsigned int, to prevent undefined behaviour in the
overflow of signed integers (overflow of unsigned int is defined
to be wrap around). Found by clang test suggested by Sean
McBride.
2011-11-30 Werner Lemberg <wl@gnu.org>
[winfonts] Remove casts.

5
src/tools/apinames.c
View file

@ -59,8 +59,9 @@ static void
names_add( const char* name,
const char* end )
{
int nn, len, h;
Name nm;
unsigned int h;
int nn, len;
Name nm;
if ( end <= name )
return;