remove target_os usage

base/base.hpp

@@ -31,5 +31,3 @@ static_assert(MY_DEBUG_DEFINED ^ MY_RELEASE_DEFINED, "Either Debug or Release sh
   #define IF_DEBUG_ELSE(a, b) (b)
 #endif
 
-// platform macroses
-#include "platform/target_os.hpp"

base/buffer_vector.hpp

@@ -27,8 +27,6 @@ private:
 
   inline bool IsDynamic() const { return m_size == USE_DYNAMIC; }
 
-  /// @todo clang on linux doesn't have is_trivially_copyable.
-#ifndef GEOCORE_OS_LINUX
   template <class U = T>
   std::enable_if_t<std::is_trivially_copyable<U>::value, void> MoveStatic(buffer_vector<T, N> & rhs)
   {
@@ -41,19 +39,6 @@ private:
     for (size_t i = 0; i < rhs.m_size; ++i)
       Swap(m_static[i], rhs.m_static[i]);
   }
-#else
-  template <class U = T>
-  std::enable_if_t<std::is_pod<U>::value, void> MoveStatic(buffer_vector<T, N> & rhs)
-  {
-    memcpy(m_static, rhs.m_static, rhs.m_size*sizeof(T));
-  }
-  template <class U = T>
-  std::enable_if_t<!std::is_pod<U>::value, void> MoveStatic(buffer_vector<T, N> & rhs)
-  {
-    for (size_t i = 0; i < rhs.m_size; ++i)
-      Swap(m_static[i], rhs.m_static[i]);
-  }
-#endif
 
 public:
   typedef T value_type;

base/string_utils.cpp

@@ -1,8 +1,6 @@
 #include "base/assert.hpp"
 #include "base/string_utils.hpp"
 
-#include "platform/target_os.hpp"
-
 #include <algorithm>
 #include <cmath>
 #include <iomanip>

base/thread.hpp

@@ -4,8 +4,6 @@
 #include "base/cancellable.hpp"
 #include "base/macros.hpp"
 
-#include "platform/target_os.hpp"
-
 #include <cstdint>
 #include <functional>
 #include <memory>

coding/internal/file_data.hpp

@@ -4,8 +4,6 @@
 #include "base/base.hpp"
 #include "base/macros.hpp"
 
-#include "platform/target_os.hpp"
-
 #include <cstddef>
 #include <cstdint>
 #include <functional>

coding/reader.hpp

@@ -273,9 +273,7 @@ inline void ReadFromPos(TReader const & reader, uint64_t pos, void * p, size_t s
 template <typename TPrimitive, class TReader>
 inline TPrimitive ReadPrimitiveFromPos(TReader const & reader, uint64_t pos)
 {
-#ifndef GEOCORE_OS_LINUX
   static_assert(std::is_trivially_copyable<TPrimitive>::value, "");
-#endif
   TPrimitive primitive;
   ReadFromPos(reader, pos, &primitive, sizeof(primitive));
   return SwapIfBigEndianMacroBased(primitive);
@@ -284,9 +282,7 @@ inline TPrimitive ReadPrimitiveFromPos(TReader const & reader, uint64_t pos)
 template <typename TPrimitive, class TSource>
 TPrimitive ReadPrimitiveFromSource(TSource & source)
 {
-#ifndef GEOCORE_OS_LINUX
   static_assert(std::is_trivially_copyable<TPrimitive>::value, "");
-#endif
   TPrimitive primitive;
   source.Read(&primitive, sizeof(primitive));
   return SwapIfBigEndianMacroBased(primitive);

docs/CPP_STYLE.md

@@ -207,7 +207,6 @@ v = w * (x + z);
 ### Some useful macros:
 
 - `#ifdef DEBUG | RELEASE | GEOCORE_PRODUCTION`
-- `#ifdef GEOCORE_OS_LINUX | GEOCORE_OS_MAC` (and some other useful OS-related macros, see `platform/target_os.hpp`)
 - Use `ASSERT(expression, (out message))` and `ASSERT_XXXXXX` macros often to check code validity in DEBUG builds
 - Use `CHECK(expression, (out message))` and `CHECK_XXXXXX` macros to check code validity in all builds
 - Use `LOG(level, (message))` for logging, below is more detailed description for level:

indexer/cell_value_pair.hpp

@@ -39,7 +39,5 @@ private:
 
 // For backward compatibility.
 static_assert(sizeof(CellValuePair<uint32_t>) == 12, "");
-#ifndef GEOCORE_OS_LINUX
 static_assert(std::is_trivially_copyable<CellValuePair<uint32_t>>::value, "");
-#endif
 }  // namespace covering

indexer/displacement_manager.hpp

@@ -13,8 +13,6 @@
 #include "geometry/screenbase.hpp"
 #include "geometry/tree4d.hpp"
 
-#include "platform/target_os.hpp"
-
 #include <algorithm>
 #include <functional>
 #include <vector>
@@ -55,9 +53,7 @@ private:
   uint32_t m_bucket;
 };
 static_assert(sizeof(CellFeatureBucketTuple) == 16, "");
-#ifndef GEOCORE_OS_LINUX
 static_assert(std::is_trivially_copyable<CellFeatureBucketTuple>::value, "");
-#endif
 
 /// Displacement manager filters incoming single-point features to simplify runtime
 /// feature visibility displacement.

indexer/drawing_rules.hpp

@@ -7,8 +7,6 @@
 #include "base/base.hpp"
 #include "base/buffer_vector.hpp"
 
-#include "platform/target_os.hpp"
-
 #include <array>
 #include <iostream>
 #include <map>

indexer/drules_include.hpp

@@ -1,5 +1,3 @@
 #pragma once
 
-#include "platform/target_os.hpp"
-
 #include "indexer/drules_struct.pb.h"

indexer/indexer_tests/trie_test.cpp

@@ -46,9 +46,7 @@ template <typename Primitive>
 class SingleValueSerializer
 {
 public:
-#if !defined(GEOCORE_OS_LINUX)
   static_assert(std::is_trivially_copyable<Primitive>::value, "");
-#endif
 
   template <typename Sink>
   void Serialize(Sink & sink, Primitive const & v) const
@@ -64,9 +62,7 @@ public:
   using Value = Primitive;
   using Serializer = SingleValueSerializer<Value>;
 
-#if !defined(GEOCORE_OS_LINUX)
   static_assert(std::is_trivially_copyable<Primitive>::value, "");
-#endif
 
   void Init(vector<Value> const & values) { m_values = values; }
 

platform/target_os.hpp

@@ -1,4 +1,5 @@
 #pragma once
+#pragma message("Using of this header means non portable code, fix it, or SUFFER")
 
 #if defined(__APPLE__)
   #include <TargetConditionals.h>

testing/testingmain.cpp

@@ -1,5 +1,3 @@
-#include "platform/target_os.hpp"
-
 #include "testing/testing.hpp"
 
 #ifndef GEOCORE_UNIT_TEST_DISABLE_PLATFORM_INIT