organicmaps/gflags
13
Fork 0
mirror of https://github.com/gflags/gflags.git synced 2025-04-04 13:05:03 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions

Remove fallthrough switch case

Browse source 
GCC gives an implicit-fallthrough warning (included in -Wextra). C++17 has the [[fallthrough]] attribute, and GCC7+ has __attribute__ ((fallthrough)), but I didn't want to require either so I refactored the switch into if statements.
This commit is contained in:
Andrew Gasparovic 2020-05-12 06:55:08 -07:00 • committed by Andreas Schuh
parent 1137acc9e0
commit 84968c6bb2
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/gflags_completions.cc
View file

@ -325,12 +325,21 @@ static void CanonicalizeCursorWordAndSearchOptions(
}
break;
}
switch (found_question_marks) { // all fallthroughs
case 3: options->flag_description_substring_search = true;
case 2: options->flag_location_substring_search = true;
case 1: options->flag_name_substring_search = true;
};
if (found_question_marks == 3) {
options->flag_description_substring_search = true;
options->flag_location_substring_search = true;
options->flag_name_substring_search = true;
}
if (found_question_marks == 2) {
options->flag_location_substring_search = true;
options->flag_name_substring_search = true;
}
if (found_question_marks == 1) {
options->flag_name_substring_search = true;
}
options->return_all_matching_flags = (found_plusses > 0);
}