organicmaps/gflags
13
Fork 0
mirror of https://github.com/gflags/gflags.git synced 2025-04-04 13:05:03 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions

Avoid no-match message in case STRIP_FLAG_HELP been set

Browse source 
If the workaround in issue #43 is used along with the define of
STRIP_FLAG_HELP to 1, there would be a wrong "No modules matched"
message been print at end of the usage message.

That's because we continue the loop if we see strip flag help value and
never set the `found_match` flag to true even if we found a match.

By moving the set statement above the continue, we can avoid this wrong
message.
This commit is contained in:
Jacky Wu 2019-11-13 15:32:13 +08:00 • committed by Andreas Schuh
parent 6c8f50b567
commit d9b184bd00
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/gflags_reporting.cc
View file

@ -275,9 +275,9 @@ static void ShowUsageWithFlagsMatching(const char *argv0,
++flag) {
if (substrings.empty() ||
FileMatchesSubstring(flag->filename, substrings)) {
found_match = true; // this flag passed the match!
// If the flag has been stripped, pretend that it doesn't exist.
if (flag->description == kStrippedFlagHelp) continue;
found_match = true; // this flag passed the match!
if (flag->filename != last_filename) { // new file
if (Dirname(flag->filename) != Dirname(last_filename)) { // new dir!
if (!first_directory)