organicmaps/glfw
13
Fork 0
mirror of https://github.com/glfw/glfw.git synced 2025-04-05 21:45:08 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions
glfw/src
History
Stephen Gutekanst 9cd4d2fa20 X11: Fix undefined behavior in glfwSetWindowIcon 
The conversion of window icon image data involves unsigned char color
values being promoted to int and then shifted to the left by 24.  For
32-bit ints this is just far enough to trigger undefined behavior.

It worked by accident because of how current compilers translate this
piece of code.

This was caught by @slimsag while working on [Zig bindings for GLFW][1],
and diagnosed together with @Andoryuuta, as described [in an
article][2].  Zig has UBSan enabled by default, which caught this
undefined behavior.

[1]: https://github.com/hexops/mach-glfw
[2]: https://devlog.hexops.com/2021/perfecting-glfw-for-zig-and-finding-undefined-behavior#finding-lurking-undefined-behavior-in-6-year-old-glfw-code

Thanks to Maato, martinhath, dcousens, drfuchs and Validark for helping
to refine the solution.

This commit message was rewritten by @elmindreda to hopefully reflect
the conclusions of the pull request thread.

Related to hexops/mach#20
Closes #1986
2021-12-01 19:05:39 +01:00
..
CMakeLists.txt Add glfwInitVulkanLoader 2021-10-27 18:22:05 +02:00
cocoa_init.m Limit scope of some loop counters in C99 files 2021-10-25 23:39:06 +02:00
cocoa_joystick.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
cocoa_joystick.m Limit scope of some loop counters in C99 files 2021-10-25 23:39:06 +02:00
cocoa_monitor.m Cocoa: Use MACH_PORT_NULL for default IOKit port 2021-11-22 21:30:53 +01:00
cocoa_platform.h Cocoa: Use MACH_PORT_NULL for default IOKit port 2021-11-22 21:30:53 +01:00
cocoa_time.c Make timer init part of platform API 2021-10-12 12:54:36 +02:00
cocoa_time.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
cocoa_window.m Add runtime platform selection 2021-10-13 21:47:11 +02:00
context.c Move single/double-buffer filtering to backends 2021-05-14 19:02:25 +02:00
egl_context.c Fix context API checks in native access functions 2021-10-23 16:20:18 +03:00
glfw.rc.in Win32: Add VERSIONINFO resource to GLFW DLL 2019-12-11 21:02:08 +01:00
glx_context.c Limit scope of some loop counters in C99 files 2021-10-25 23:39:06 +02:00
init.c Update comments for global mutable data 2021-11-25 23:24:39 +01:00
input.c Fix invalid pointer conversions 2021-10-27 18:22:05 +02:00
internal.h Add glfwInitVulkanLoader 2021-10-27 18:22:05 +02:00
linux_joystick.c Limit scope of some loop counters in C99 files 2021-10-25 23:39:06 +02:00
linux_joystick.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
mappings.h Simplify parsing of default gamepad mappings 2021-08-01 20:57:28 +02:00
mappings.h.in Simplify parsing of default gamepad mappings 2021-08-01 20:57:28 +02:00
monitor.c Fix invalid pointer conversions 2021-10-27 18:22:05 +02:00
nsgl_context.m Fix context API checks in native access functions 2021-10-23 16:20:18 +03:00
null_init.c Add runtime platform selection 2021-10-13 21:47:11 +02:00
null_joystick.c Add runtime platform selection 2021-10-13 21:47:11 +02:00
null_joystick.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
null_monitor.c Add runtime platform selection 2021-10-13 21:47:11 +02:00
null_platform.h Null: Remove unused function 2021-10-27 18:22:05 +02:00
null_window.c Null: Remove unused function 2021-10-27 18:22:05 +02:00
osmesa_context.c Fix context API checks in native access functions 2021-10-23 16:20:18 +03:00
platform.c Gather Null specific platform selection logic 2021-11-25 23:24:39 +01:00
platform.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
posix_module.c Make dynamic module loading part of platform API 2021-10-12 12:54:36 +02:00
posix_thread.c Add C dialect reminders to each source file 2019-05-24 14:43:49 +02:00
posix_thread.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
posix_time.c Make timer init part of platform API 2021-10-12 12:54:36 +02:00
posix_time.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
vulkan.c Add glfwInitVulkanLoader 2021-10-27 18:22:05 +02:00
wgl_context.c WGL: Limit DWM swap interval hack to Vista and 7 2021-10-27 18:22:05 +02:00
win32_init.c Add runtime platform selection 2021-10-13 21:47:11 +02:00
win32_joystick.c Add runtime platform selection 2021-10-13 21:47:11 +02:00
win32_joystick.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
win32_module.c Make dynamic module loading part of platform API 2021-10-12 12:54:36 +02:00
win32_monitor.c Add runtime platform selection 2021-10-13 21:47:11 +02:00
win32_platform.h Fix various typos 2021-10-25 23:39:06 +02:00
win32_thread.c Win32: Make thread functions backend independent 2021-10-12 12:54:36 +02:00
win32_thread.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
win32_time.c Win32: Remove timeGetTime fallback for timer 2021-10-12 12:54:37 +02:00
win32_time.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
win32_window.c Add runtime platform selection 2021-10-13 21:47:11 +02:00
window.c Fix invalid pointer conversions 2021-10-27 18:22:05 +02:00
wl_init.c Limit scope of some loop counters in C99 files 2021-10-25 23:39:06 +02:00
wl_monitor.c Add runtime platform selection 2021-10-13 21:47:11 +02:00
wl_platform.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
wl_window.c Limit scope of some loop counters in C99 files 2021-10-25 23:39:06 +02:00
x11_init.c Limit scope of some loop counters in C99 files 2021-10-25 23:39:06 +02:00
x11_monitor.c Add runtime platform selection 2021-10-13 21:47:11 +02:00
x11_platform.h Add runtime platform selection 2021-10-13 21:47:11 +02:00
x11_window.c X11: Fix undefined behavior in glfwSetWindowIcon 2021-12-01 19:05:39 +01:00
xkb_unicode.c Add C dialect reminders to each source file 2019-05-24 14:43:49 +02:00
xkb_unicode.h Start 3.4 2019-04-16 23:08:39 +02:00