From bd192a395515f73b6be43e2ffdacdd15989b999b Mon Sep 17 00:00:00 2001 From: Adam Lusch Date: Fri, 21 Mar 2025 17:30:13 -0500 Subject: [PATCH 1/3] Avoid "implicit conversion increases floating-point precision: 'float' to 'double'" --- glm/detail/func_common.inl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glm/detail/func_common.inl b/glm/detail/func_common.inl index 7dd982d5..108a0330 100644 --- a/glm/detail/func_common.inl +++ b/glm/detail/func_common.inl @@ -345,7 +345,7 @@ namespace detail template GLM_FUNC_QUALIFIER GLM_CONSTEXPR static vec call(vec const& a) { - vec v(0.0f); + vec v(0); for (int i = 0; i < L; ++i) v[i] = a[c]; return v; From 9d354b2b55aeb6af9604f32f5fd3b5b8f7fe7eb8 Mon Sep 17 00:00:00 2001 From: Adam Lusch Date: Fri, 21 Mar 2025 17:35:01 -0500 Subject: [PATCH 2/3] NEON mask order is flipped --- glm/detail/func_common_simd.inl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glm/detail/func_common_simd.inl b/glm/detail/func_common_simd.inl index 818bb1f5..e775fab5 100644 --- a/glm/detail/func_common_simd.inl +++ b/glm/detail/func_common_simd.inl @@ -553,7 +553,7 @@ namespace glm { GLM_FUNC_QUALIFIER static vec<4, float, Q> call(vec<3, float, Q> const& a) { vec<4, float, Q> v; - static const uint32x4_t mask = { 0, 0xFFFFFFFF, 0xFFFFFFFF, 0xFFFFFFFF }; + static const uint32x4_t mask = { 0xFFFFFFFF, 0xFFFFFFFF, 0xFFFFFFFF, 0 }; v.data = vbslq_f32(mask, a.data, vdupq_n_f32(0)); return v; } From a6431989fb3548efc84cce717a047069e823dee4 Mon Sep 17 00:00:00 2001 From: Adam Lusch Date: Fri, 21 Mar 2025 17:41:12 -0500 Subject: [PATCH 3/3] Enable test for NEON --- test/gtc/gtc_type_aligned.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/gtc/gtc_type_aligned.cpp b/test/gtc/gtc_type_aligned.cpp index 19a3aafc..1b62c03d 100644 --- a/test/gtc/gtc_type_aligned.cpp +++ b/test/gtc/gtc_type_aligned.cpp @@ -1,6 +1,6 @@ #include -#if GLM_CONFIG_ALIGNED_GENTYPES == GLM_ENABLE && !(GLM_ARCH & GLM_ARCH_NEON_BIT) // Fail on Github macOS latest C.I. +#if GLM_CONFIG_ALIGNED_GENTYPES == GLM_ENABLE #include #include #include