From f6f673710b19cf39630c4745a14101f9349fcc72 Mon Sep 17 00:00:00 2001 From: RedMarcher Date: Thu, 21 Nov 2024 20:37:03 +0000 Subject: [PATCH 1/5] Created new flag for machine result feature --- googletest/include/gtest/gtest.h | 4 ++++ googletest/src/gtest-internal-inl.h | 9 ++++++--- googletest/src/gtest.cc | 23 +++++++++++++++-------- 3 files changed, 25 insertions(+), 11 deletions(-) diff --git a/googletest/include/gtest/gtest.h b/googletest/include/gtest/gtest.h index c8996695..59025d20 100644 --- a/googletest/include/gtest/gtest.h +++ b/googletest/include/gtest/gtest.h @@ -152,6 +152,10 @@ GTEST_DECLARE_int32_(stack_trace_depth); // non-zero code otherwise. For use with an external test framework. GTEST_DECLARE_bool_(throw_on_failure); +// When this flag is set, results are streamed to stdout +// without pretty-print formatting +GTEST_DECLARE_bool_(machine_results); + // When this flag is set with a "host:port" string, on supported // platforms test results are streamed to the specified port on // the specified host machine. diff --git a/googletest/src/gtest-internal-inl.h b/googletest/src/gtest-internal-inl.h index cc6f0048..fa9ab6dc 100644 --- a/googletest/src/gtest-internal-inl.h +++ b/googletest/src/gtest-internal-inl.h @@ -162,8 +162,9 @@ class GTestFlagSaver { GTEST_FLAG_GET(recreate_environments_when_repeating); shuffle_ = GTEST_FLAG_GET(shuffle); stack_trace_depth_ = GTEST_FLAG_GET(stack_trace_depth); - stream_result_to_ = GTEST_FLAG_GET(stream_result_to); throw_on_failure_ = GTEST_FLAG_GET(throw_on_failure); + machine_results_ = GTEST_FLAG_GET(machine_results); + stream_result_to_ = GTEST_FLAG_GET(stream_result_to); } // The d'tor is not virtual. DO NOT INHERIT FROM THIS CLASS. @@ -188,8 +189,9 @@ class GTestFlagSaver { recreate_environments_when_repeating_); GTEST_FLAG_SET(shuffle, shuffle_); GTEST_FLAG_SET(stack_trace_depth, stack_trace_depth_); - GTEST_FLAG_SET(stream_result_to, stream_result_to_); GTEST_FLAG_SET(throw_on_failure, throw_on_failure_); + GTEST_FLAG_SET(machine_results, machine_results_); + GTEST_FLAG_SET(stream_result_to, stream_result_to_); } private: @@ -213,8 +215,9 @@ class GTestFlagSaver { bool recreate_environments_when_repeating_; bool shuffle_; int32_t stack_trace_depth_; - std::string stream_result_to_; bool throw_on_failure_; + bool machine_results_; + std::string stream_result_to_; }; // Converts a Unicode code point to a narrow string in UTF-8 encoding. diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc index c08ab419..0153ecac 100644 --- a/googletest/src/gtest.cc +++ b/googletest/src/gtest.cc @@ -374,13 +374,6 @@ GTEST_DEFINE_int32_( "The maximum number of stack frames to print when an " "assertion fails. The valid range is 0 through 100, inclusive."); -GTEST_DEFINE_string_( - stream_result_to, - testing::internal::StringFromGTestEnv("stream_result_to", ""), - "This flag specifies the host name and the port number on which to stream " - "test results. Example: \"localhost:555\". The flag is effective only on " - "Linux and macOS."); - GTEST_DEFINE_bool_( throw_on_failure, testing::internal::BoolFromGTestEnv("throw_on_failure", false), @@ -388,6 +381,19 @@ GTEST_DEFINE_bool_( "if exceptions are enabled or exit the program with a non-zero code " "otherwise. For use with an external test framework."); +GTEST_DEFINE_bool_( + machine_results, + testing::internal::BoolFromGTestEnv("machine_results", false), + "When this flag is specified, results are streamed to stdout " + "without pretty-printing. Uses the same format as stream_result_to"); + +GTEST_DEFINE_string_( + stream_result_to, + testing::internal::StringFromGTestEnv("stream_result_to", ""), + "This flag specifies the host name and the port number on which to stream " + "test results. Example: \"localhost:555\". The flag is effective only on " + "Linux and macOS."); + #if GTEST_USE_OWN_FLAGFILE_FLAG_ GTEST_DEFINE_string_( flagfile, testing::internal::StringFromGTestEnv("flagfile", ""), @@ -6667,8 +6673,9 @@ static bool ParseGoogleTestFlag(const char* const arg) { GTEST_INTERNAL_PARSE_FLAG(recreate_environments_when_repeating); GTEST_INTERNAL_PARSE_FLAG(shuffle); GTEST_INTERNAL_PARSE_FLAG(stack_trace_depth); - GTEST_INTERNAL_PARSE_FLAG(stream_result_to); GTEST_INTERNAL_PARSE_FLAG(throw_on_failure); + GTEST_INTERNAL_PARSE_FLAG(machine_results); + GTEST_INTERNAL_PARSE_FLAG(stream_result_to); return false; } From 947270bf57a3a68ff40b907d4befff6a43cf7a4b Mon Sep 17 00:00:00 2001 From: RedMarcher Date: Thu, 21 Nov 2024 21:08:19 +0000 Subject: [PATCH 2/5] Began to add testing for machine_results --- .vscode/settings.json | 3 ++ googletest/test/gtest_unittest.cc | 77 ++++++++++++++++++++----------- 2 files changed, 53 insertions(+), 27 deletions(-) create mode 100644 .vscode/settings.json diff --git a/.vscode/settings.json b/.vscode/settings.json new file mode 100644 index 00000000..70e34ecb --- /dev/null +++ b/.vscode/settings.json @@ -0,0 +1,3 @@ +{ + "C_Cpp.errorSquiggles": "disabled" +} \ No newline at end of file diff --git a/googletest/test/gtest_unittest.cc b/googletest/test/gtest_unittest.cc index 2d48deef..1c75b7fb 100644 --- a/googletest/test/gtest_unittest.cc +++ b/googletest/test/gtest_unittest.cc @@ -48,8 +48,9 @@ TEST(CommandLineFlagsTest, CanBeAccessedInCodeOnceGTestHIsIncluded) { GTEST_FLAG_GET(recreate_environments_when_repeating) || GTEST_FLAG_GET(show_internal_stack_frames) || GTEST_FLAG_GET(shuffle) || GTEST_FLAG_GET(stack_trace_depth) > 0 || - GTEST_FLAG_GET(stream_result_to) != "unknown" || - GTEST_FLAG_GET(throw_on_failure); + GTEST_FLAG_GET(throw_on_failure) || + GTEST_FLAG_GET(machine_results) || + GTEST_FLAG_GET(stream_result_to) != "unknown"; EXPECT_TRUE(dummy || !dummy); // Suppresses warning that dummy is unused. } @@ -1618,8 +1619,9 @@ class GTestFlagSaverTest : public Test { GTEST_FLAG_SET(recreate_environments_when_repeating, true); GTEST_FLAG_SET(shuffle, false); GTEST_FLAG_SET(stack_trace_depth, kMaxStackTraceDepth); - GTEST_FLAG_SET(stream_result_to, ""); GTEST_FLAG_SET(throw_on_failure, false); + GTEST_FLAG_SET(machine_results, false); + GTEST_FLAG_SET(stream_result_to, ""); } // Restores the Google Test flags that the tests have modified. This will @@ -1648,8 +1650,9 @@ class GTestFlagSaverTest : public Test { EXPECT_TRUE(GTEST_FLAG_GET(recreate_environments_when_repeating)); EXPECT_FALSE(GTEST_FLAG_GET(shuffle)); EXPECT_EQ(kMaxStackTraceDepth, GTEST_FLAG_GET(stack_trace_depth)); - EXPECT_STREQ("", GTEST_FLAG_GET(stream_result_to).c_str()); EXPECT_FALSE(GTEST_FLAG_GET(throw_on_failure)); + EXPECT_FALSE(GTEST_FLAG_GET(machine_results)); + EXPECT_STREQ("", GTEST_FLAG_GET(stream_result_to).c_str()); GTEST_FLAG_SET(also_run_disabled_tests, true); GTEST_FLAG_SET(break_on_failure, true); @@ -1667,8 +1670,9 @@ class GTestFlagSaverTest : public Test { GTEST_FLAG_SET(recreate_environments_when_repeating, false); GTEST_FLAG_SET(shuffle, true); GTEST_FLAG_SET(stack_trace_depth, 1); - GTEST_FLAG_SET(stream_result_to, "localhost:1234"); GTEST_FLAG_SET(throw_on_failure, true); + GTEST_FLAG_SET(machine_results, true); + GTEST_FLAG_SET(stream_result_to, "localhost:1234"); } private: @@ -5537,8 +5541,9 @@ struct Flags { recreate_environments_when_repeating(true), shuffle(false), stack_trace_depth(kMaxStackTraceDepth), - stream_result_to(""), - throw_on_failure(false) {} + throw_on_failure(false), + machine_results(false), + stream_result_to("") {} // Factory methods. @@ -5664,6 +5669,22 @@ struct Flags { return flags; } + // Creates a Flags struct where the GTEST_FLAG(throw_on_failure) flag has + // the given value. + static Flags ThrowOnFailure(bool throw_on_failure) { + Flags flags; + flags.throw_on_failure = throw_on_failure; + return flags; + } + + // Creates a Flags struct where GTEST_FLAG(machine_results) flag has + // the given value + static Flags MachineResults(bool machine_results) { + Flags flags; + flags.machine_results = machine_results; + return flags; + } + // Creates a Flags struct where the GTEST_FLAG(stream_result_to) flag has // the given value. static Flags StreamResultTo(const char* stream_result_to) { @@ -5672,13 +5693,6 @@ struct Flags { return flags; } - // Creates a Flags struct where the gtest_throw_on_failure flag has - // the given value. - static Flags ThrowOnFailure(bool throw_on_failure) { - Flags flags; - flags.throw_on_failure = throw_on_failure; - return flags; - } // These fields store the flag values. bool also_run_disabled_tests; @@ -5696,8 +5710,9 @@ struct Flags { bool recreate_environments_when_repeating; bool shuffle; int32_t stack_trace_depth; - const char* stream_result_to; bool throw_on_failure; + bool machine_results; + const char* stream_result_to; }; // Fixture for testing ParseGoogleTestFlagsOnly(). @@ -5720,8 +5735,9 @@ class ParseFlagsTest : public Test { GTEST_FLAG_SET(recreate_environments_when_repeating, true); GTEST_FLAG_SET(shuffle, false); GTEST_FLAG_SET(stack_trace_depth, kMaxStackTraceDepth); - GTEST_FLAG_SET(stream_result_to, ""); GTEST_FLAG_SET(throw_on_failure, false); + GTEST_FLAG_SET(machine_results, false); + GTEST_FLAG_SET(stream_result_to, ""); } // Asserts that two narrow or wide string arrays are equal. @@ -5755,9 +5771,10 @@ class ParseFlagsTest : public Test { GTEST_FLAG_GET(recreate_environments_when_repeating)); EXPECT_EQ(expected.shuffle, GTEST_FLAG_GET(shuffle)); EXPECT_EQ(expected.stack_trace_depth, GTEST_FLAG_GET(stack_trace_depth)); + EXPECT_EQ(expected.throw_on_failure, GTEST_FLAG_GET(throw_on_failure)); + EXPECT_EQ(expected.machine_results, GTEST_FLAG_GET(machine_results)); EXPECT_STREQ(expected.stream_result_to, GTEST_FLAG_GET(stream_result_to).c_str()); - EXPECT_EQ(expected.throw_on_failure, GTEST_FLAG_GET(throw_on_failure)); } // Parses a command line (specified by argc1 and argv1), then @@ -6195,16 +6212,6 @@ TEST_F(ParseFlagsTest, StackTraceDepth) { GTEST_TEST_PARSING_FLAGS_(argv, argv2, Flags::StackTraceDepth(5), false); } -TEST_F(ParseFlagsTest, StreamResultTo) { - const char* argv[] = {"foo.exe", "--gtest_stream_result_to=localhost:1234", - nullptr}; - - const char* argv2[] = {"foo.exe", nullptr}; - - GTEST_TEST_PARSING_FLAGS_(argv, argv2, - Flags::StreamResultTo("localhost:1234"), false); -} - // Tests parsing --gtest_throw_on_failure. TEST_F(ParseFlagsTest, ThrowOnFailureWithoutValue) { const char* argv[] = {"foo.exe", "--gtest_throw_on_failure", nullptr}; @@ -6233,6 +6240,22 @@ TEST_F(ParseFlagsTest, ThrowOnFailureTrue) { GTEST_TEST_PARSING_FLAGS_(argv, argv2, Flags::ThrowOnFailure(true), false); } +// Tests parsing --gtest_machine_results +TEST_F(ParseFlagsTest, MachineResultsTrue) { + // TODO +} + +// Tests parsing --gtest_stream_result_to flag that is set to localhost:1234 +TEST_F(ParseFlagsTest, StreamResultTo) { + const char* argv[] = {"foo.exe", "--gtest_stream_result_to=localhost:1234", + nullptr}; + + const char* argv2[] = {"foo.exe", nullptr}; + + GTEST_TEST_PARSING_FLAGS_(argv, argv2, + Flags::StreamResultTo("localhost:1234"), false); +} + // Tests parsing a bad --gtest_filter flag. TEST_F(ParseFlagsTest, FilterBad) { const char* argv[] = {"foo.exe", "--gtest_filter", nullptr}; From fa4b65e9312f3b45116466bb289e604461bdda3c Mon Sep 17 00:00:00 2001 From: RedMarcher Date: Thu, 21 Nov 2024 13:15:36 -0800 Subject: [PATCH 3/5] Deleted spurrious change No idea what caused this. This isn't supposed to be changed --- .vscode/settings.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 70e34ecb..8b137891 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,3 +1 @@ -{ - "C_Cpp.errorSquiggles": "disabled" -} \ No newline at end of file + From 269de132b5a1fc290be4bc24da6b36bdcff9031c Mon Sep 17 00:00:00 2001 From: RedMarcher Date: Thu, 21 Nov 2024 13:16:21 -0800 Subject: [PATCH 4/5] Delete spurious change part 2 FInally removed this unwanted change --- .vscode/settings.json | 1 - 1 file changed, 1 deletion(-) delete mode 100644 .vscode/settings.json diff --git a/.vscode/settings.json b/.vscode/settings.json deleted file mode 100644 index 8b137891..00000000 --- a/.vscode/settings.json +++ /dev/null @@ -1 +0,0 @@ - From 4b1c234b2af7fbbc70da89e53e1a66d39f8ddb1d Mon Sep 17 00:00:00 2001 From: RedMarcher Date: Wed, 27 Nov 2024 00:24:42 +0000 Subject: [PATCH 5/5] Began to implement print to terminal --- googletest/src/gtest.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc index 0153ecac..075631d5 100644 --- a/googletest/src/gtest.cc +++ b/googletest/src/gtest.cc @@ -5729,6 +5729,12 @@ void UnitTestImpl::ConfigureXmlOutput() { #endif // GTEST_HAS_FILE_SYSTEM } +#if GTEST_HAS_TERMINAL +void PrintToTerminal() { + // Unsure of whether to use listener system, or to try and print events directly to terminal +} +#endif // GTEST_HAS_TERMINAL + #if GTEST_CAN_STREAM_RESULTS_ // Initializes event listeners for streaming test results in string form. // Must not be called before InitGoogleTest.