organicmaps/googletest
13
Fork 0
mirror of https://github.com/google/googletest.git synced 2025-04-07 06:25:01 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions

fix: explicitly copy-convert to std::string in StartsWith/EndsWith matchers

Browse source 
Instead of relying on automatic conversions, which won't happen if
they're explicit!
This commit is contained in:
Giel van Schijndel 2023-10-12 16:24:06 +02:00
parent a6d7fa8c0c
commit c618dd98d0
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
googlemock/include/gmock/gmock-matchers.h
View file

@ -1048,7 +1048,7 @@ class StartsWithMatcher {
template <typename MatcheeStringType>
bool MatchAndExplain(const MatcheeStringType& s,
MatchResultListener* /* listener */) const {
const StringType& s2(s);
const StringType s2(s);
return s2.length() >= prefix_.length() &&
s2.substr(0, prefix_.length()) == prefix_;
}
@ -1102,7 +1102,7 @@ class EndsWithMatcher {
template <typename MatcheeStringType>
bool MatchAndExplain(const MatcheeStringType& s,
MatchResultListener* /* listener */) const {
const StringType& s2(s);
const StringType s2(s);
return s2.length() >= suffix_.length() &&
s2.substr(s2.length() - suffix_.length()) == suffix_;
}