From 190ad35f71084e6265f4dc81fbdf7a2deb06e235 Mon Sep 17 00:00:00 2001 From: Khaled Hosny Date: Tue, 25 Mar 2025 16:34:19 +0200 Subject: [PATCH] =?UTF-8?q?[test/shape]=20Don=E2=80=99t=20skip=20test=20if?= =?UTF-8?q?=20`hb-shape=20--list-*`=20fails?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This can happen with Wine when, e.g., `WINEPATH` is not set, and we would silently skip the tests because lists of supported shapers etc. are empty. --- test/shape/run-tests.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/shape/run-tests.py b/test/shape/run-tests.py index daa1312cd..f7639d42b 100755 --- a/test/shape/run-tests.py +++ b/test/shape/run-tests.py @@ -97,6 +97,8 @@ for what in ["shaper", "face-loader", "font-funcs"]: ) # Capture the output what_list = what_process.communicate()[0].decode("utf-8").strip().split() + if what_process.returncode: + sys.exit(f"Failed to run: {hb_shape} {subcommand}") whats = plural(what) var_name = supported_whats_var_name(what) globals()[var_name] = what_list