organicmaps/harfbuzz
13
Fork 0
mirror of https://github.com/harfbuzz/harfbuzz.git synced 2025-04-04 13:05:04 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 7

[ot/ft] Round glyph extents instead of floor/ceil
Some checks failed
arm / arm-none-eabi (push) Waiting to run
Details
configs-ci / build (push) Waiting to run
Details
fontations / build (push) Waiting to run
Details
linux-ci / build (push) Waiting to run
Details
macos-ci / build (push) Waiting to run
Details
msvc / msvc-2019-amd64 (push) Waiting to run
Details
msvc / msvc-2019-x86 (push) Waiting to run
Details
msys2 / CLANG64 (push) Waiting to run
Details
msys2 / MINGW32 (push) Waiting to run
Details
msys2 / MINGW64 (push) Waiting to run
Details
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Details

Browse source 
1. The floor/ceil was being applied in the wrong order for y direction.
2. If the scale is negative, the floor/ceil should be reversed.

Just round them instead. That's what coretext / directwrite / fontations
font-funcs do.
This commit is contained in:
Behdad Esfahbod 2025-03-30 17:04:08 -06:00
parent 4954edb2b1
commit 4cf4099f07
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/hb-font.hh
View file

@ -198,10 +198,10 @@ struct hb_font_t
float x2 = em_scale_x (extents->x_bearing + extents->width);
float y2 = em_scale_y (extents->y_bearing + extents->height);
extents->x_bearing = floorf (x1);
extents->y_bearing = floorf (y1);
extents->width = ceilf (x2) - extents->x_bearing;
extents->height = ceilf (y2) - extents->y_bearing;
extents->x_bearing = round (x1);
extents->y_bearing = round (y1);
extents->width = round (x2) - extents->x_bearing;
extents->height = round (y2) - extents->y_bearing;
}
void synthetic_glyph_extents (hb_glyph_extents_t *extents)

8
src/hb-ft.cc
View file

@ -667,10 +667,10 @@ hb_ft_get_glyph_extents (hb_font_t *font,
float x2 = x1 + x_mult * ft_face->glyph->metrics.width;
float y2 = y1 + y_mult * -ft_face->glyph->metrics.height;
extents->x_bearing = floorf (x1);
extents->y_bearing = floorf (y1);
extents->width = ceilf (x2) - extents->x_bearing;
extents->height = ceilf (y2) - extents->y_bearing;
extents->x_bearing = round (x1);
extents->y_bearing = round (y1);
extents->width = round (x2) - extents->x_bearing;
extents->height = round (y2) - extents->y_bearing;
return true;
}