organicmaps/harfbuzz
13
Fork 0
mirror of https://github.com/harfbuzz/harfbuzz.git synced 2025-04-05 21:45:06 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 7

[subset] Make sure the clamp is done in a int64_t space

Browse source 
Otherwise nags about things like this,

In member function ‘int64_t graph::graph_t::vertex_t::modified_distance(unsigned int) const’,
    inlined from ‘void graph::graph_t::sort_shortest_distance()’ at ../src/graph/graph.hh:626:24:
../src/graph/graph.hh:371:20: warning: dangling pointer to an unnamed temporary may be used [-Wdangling-pointer=]
  371 |           hb_clamp (distance + distance_modifier (), (uint64_t) 0, (uint64_t) 0x7FFFFFFFFFF);
      |           ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

And some of the CI bots fail also like this https://github.com/harfbuzz/harfbuzz/actions/runs/9838686960/job/27159310858?pr=4793

But it probably something else also can be improved which maybe is out of scope for this particular change.
This commit is contained in:
Ebrahim Byagowi 2024-07-08 15:33:39 +03:30 • committed by Behdad Esfahbod
parent 495937f96d
commit 677d6646a1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/graph/graph.hh
View file

@ -368,7 +368,7 @@ struct graph_t
// it's parent where possible.
int64_t modified_distance =
hb_clamp (distance + distance_modifier (), 0, 0x7FFFFFFFFFF);
hb_clamp (distance + distance_modifier (), (int64_t) 0, 0x7FFFFFFFFFF);
if (has_max_priority ()) {
modified_distance = 0;
}