organicmaps/harfbuzz
13
Fork 0
mirror of https://github.com/harfbuzz/harfbuzz.git synced 2025-04-10 07:18:39 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 7

[font-funcs-using] Apply review feedback

Browse source
This commit is contained in:
Behdad Esfahbod 2025-03-08 12:23:41 -07:00
parent fae9d2ab27
commit 712a403bec
4 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/hb-font.cc
View file

@ -2389,8 +2389,10 @@ void free_static_font_funcs_list ()
*
* Retrieves the list of font functions supported by HarfBuzz.
*
* Return value: (transfer none) (array zero-terminated=1): an array of
* constant strings
* Return value: (transfer none) (array zero-terminated=1): a
* `NULL`-terminated array of supported font functions
* constant string. The returned array is owned by HarfBuzz
* and should not be modified or freed.
*
* XSince: REPLACEME
**/

4
src/hb-shape.cc
View file

@ -93,6 +93,10 @@ void free_static_shaper_list ()
*
* Return value: (transfer none) (array zero-terminated=1): an array of
* constant strings
* Return value: (transfer none) (array zero-terminated=1): a
* `NULL`-terminated array of supported shapers constant string.
* The returned array is owned by HarfBuzz and should not be
* modified or freed.
*
* Since: 0.9.2
**/

9
test/api/test-draw.c
View file

@ -1088,7 +1088,8 @@ test_hb_draw_funcs (const char* font_funcs_name)
{
hb_face_t *face = hb_test_open_font_file ("fonts/glyphs.ttf");
hb_font_t *font = hb_font_create (face);
hb_font_set_funcs_using (font, font_funcs_name);
hb_bool_t ret = hb_font_set_funcs_using (font, font_funcs_name);
g_assert (ret);
hb_face_destroy (face);
{
draw_data.consumed = 0;
@ -1107,7 +1108,8 @@ test_hb_draw_funcs (const char* font_funcs_name)
{
hb_face_t *face = hb_test_open_font_file ("fonts/cff1_flex.otf");
hb_font_t *font = hb_font_create (face);
hb_font_set_funcs_using (font, font_funcs_name);
hb_bool_t ret = hb_font_set_funcs_using (font, font_funcs_name);
g_assert (ret);
hb_face_destroy (face);
draw_data.consumed = 0;
@ -1148,7 +1150,8 @@ test_hb_draw_compare_ot_funcs (const char* font_funcs_name)
hb_font_draw_glyph (font, 1, funcs, &draw_data);
draw_data.str[draw_data.consumed] = '\0';
hb_font_set_funcs_using (font, font_funcs_name);
hb_bool_t ret = hb_font_set_funcs_using (font, font_funcs_name);
g_assert (ret);
hb_font_draw_glyph (font, 1, funcs, &draw_data2);
draw_data2.str[draw_data2.consumed] = '\0';

4
test/api/test-multithread.c
View file

@ -95,8 +95,8 @@ thread_func (void *data)
static void
test_body (const char *backend)
{
if (!hb_font_set_funcs_using (font, backend))
return;
bool ret = hb_font_set_funcs_using (font, backend);
g_assert (ret);
int i;
pthread_t *threads = calloc (num_threads, sizeof (pthread_t));