organicmaps/harfbuzz
13
Fork 0
mirror of https://github.com/harfbuzz/harfbuzz.git synced 2025-04-05 05:25:05 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 9

[directwrite] Don’t release IDWriteFace pass to hb_directwrite_font_create

Browse source 
That was a leftover from previous code and is incorrect now as we would
be double releasing it.
This commit is contained in:
Khaled Hosny 2025-03-23 15:27:36 +02:00
parent c226da8c35
commit 8d62ad3b35
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/hb-directwrite.cc
View file

@ -346,7 +346,7 @@ hb_directwrite_font_create (IDWriteFontFace *dw_face)
hb_face_destroy (face);
if (unlikely (hb_object_is_immutable (font)))
goto done;
return font;
/* Copy font variations */
if (SUCCEEDED (dw_face->QueryInterface (__uuidof (IDWriteFontFace5), (void**) &dw_face5)))
@ -378,8 +378,6 @@ hb_directwrite_font_create (IDWriteFontFace *dw_face)
dw_face->AddRef ();
font->data.directwrite.cmpexch (nullptr, (hb_directwrite_font_data_t *) dw_face);
done:
dw_face->Release ();
return font;
}

6
test/api/test-directwrite.cc
View file

@ -45,8 +45,7 @@ get_dwfontface (const char *font_path)
dw_font_face->AddRef ();
// Don't destroy face, as dw_font_face is backed by its data I think.
//hb_face_destroy (face);
hb_face_destroy (face);
return dw_font_face;
}
@ -127,8 +126,7 @@ test_native_directwrite_variations (void)
hb_font_destroy (font);
// FIXME: This crashes!
//dw_facevariations->Release ();
dw_facevariations->Release ();
}