From 8efd2d85c78fbba6ca09a3e454f77525f3b296ce Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Thu, 6 Feb 2025 14:38:09 +0000 Subject: [PATCH] [coretext] Fix CGFont leak --- src/hb-coretext-shape.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/hb-coretext-shape.cc b/src/hb-coretext-shape.cc index 73443796d..3003ba8a5 100644 --- a/src/hb-coretext-shape.cc +++ b/src/hb-coretext-shape.cc @@ -384,9 +384,9 @@ hb_coretext_face_create_from_file_or_fail (const char *file_name, (CTFontDescriptorRef) CFArrayGetValueAtIndex (ct_font_desc_array, index) : nullptr; if (unlikely (!ct_font_desc)) { - CFRelease (ct_font_desc_array); - CFRelease (url); - return nullptr; + CFRelease (ct_font_desc_array); + CFRelease (url); + return nullptr; } CFRelease (url); auto ct_font = ct_font_desc ? CTFontCreateWithFontDescriptor (ct_font_desc, 0, nullptr) : nullptr; @@ -400,6 +400,7 @@ hb_coretext_face_create_from_file_or_fail (const char *file_name, return nullptr; hb_face_t *face = hb_coretext_face_create (cg_font); + CFRelease (cg_font); if (unlikely (hb_face_is_immutable (face))) return nullptr;