organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-14 09:21:03 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 2

Fix comment

Browse source
This commit is contained in:
Tim Chevalier 2024-06-18 12:54:40 -07:00
parent e50813438f
commit 002f9b2425
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
icu4c/source/i18n/messageformat2_function_registry.cpp
View file

@ -1068,9 +1068,6 @@ SimpleTimeZone* createTimeZonePart(const UnicodeString& offsetStr, UErrorCode& e
}
int32_t offset = sign * (static_cast<int32_t>(tzHour) * 60 + static_cast<int32_t>(tzMin)) * 60 * 1000;
LocalPointer<SimpleTimeZone> tz(new SimpleTimeZone(offset, UnicodeString("GMT") + offsetStr));
/*
Use tz.getIanaID() to get the time zone name
*/
if (!tz.isValid()) {
errorCode = U_MEMORY_ALLOCATION_ERROR;
}
@ -1131,6 +1128,7 @@ static DateInfo createDateInfoFromString(const UnicodeString& sourceStr, UErrorC
offsetPart = sourceStr.tempSubString(indexOfSign, sourceStr.length());
}
}
const TimeZone* tz;
if (hasTimeZone) {
if (isGMT) {
@ -1148,13 +1146,16 @@ static DateInfo createDateInfoFromString(const UnicodeString& sourceStr, UErrorC
return {};
}
UnicodeString tzID;
// This doesn't work for offsets -- TODO
// TODO:
// Here, tz.getIanaID() should be called to normalize the time zone name.
// But it doesn't seem to work for strings with offsets, like GMT+03:30
// tz.getIanaID(timeZoneId, timeZoneName, errorCode);
tz->getID(tzID);
// Empty string for Gregorian calendar (default);
// `:datetime` `calendar` option not implemented yet,
// so other calendars aren't implemented
return { absoluteDate, tzID, {} };
}