organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-10 07:39:16 +00:00
Code Issues1 Projects Releases Wiki Activity Actions1

ICU-20453 Add more warning types to CI build.

Browse source 
See
This commit is contained in:
Shane F. Carr 2019-09-10 04:14:43 +00:00 • committed by Shane F. Carr
parent c2687d9379
commit 051d6a553e
3 changed files with 7 additions and 7 deletions
.ci-builds
.azure-pipelines.yml
icu4c/source/test/intltest
strtest.cppstrtest.h

6
.ci-builds/.azure-pipelines.yml
View file

@ -44,7 +44,7 @@ jobs:
vmImage: 'Ubuntu 16.04'
steps:
- script: |
export CPPFLAGS="-Werror -Wall -Wextra -Wextra-semi" && cd icu4c/source && ./runConfigureICU Linux && make -j2 tests
export CPPFLAGS="-Werror -Wall -Wextra -Wextra-semi -Wundef -Wnon-virtual-dtor" && cd icu4c/source && ./runConfigureICU Linux && make -j2 tests
displayName: 'Build only (WarningsAsErrors)'
env:
CC: clang
@ -276,8 +276,8 @@ jobs:
vmImage: 'macOS-10.14'
steps:
- script: |
export CPPFLAGS="-Werror -Wall -Wextra -Wextra-semi" && cd icu4c/source && ./runConfigureICU MacOSX && make -j2 tests
export CPPFLAGS="-Werror -Wall -Wextra -Wextra-semi -Wundef -Wnon-virtual-dtor" && cd icu4c/source && ./runConfigureICU MacOSX && make -j2 tests
displayName: 'Build only (WarningsAsErrors)'
env:
CC: clang
CXX: clang++
CXX: clang++

6
icu4c/source/test/intltest/strtest.cpp
View file

@ -14,7 +14,7 @@
* created by: Markus W. Scherer
*/
#if U_HAVE_STRING_VIEW
#ifdef U_HAVE_STRING_VIEW
#include <string_view>
#endif
@ -244,7 +244,7 @@ void StringTest::runIndexedTest(int32_t index, UBool exec, const char *&name, ch
TESTCASE_AUTO(TestStringPiece);
TESTCASE_AUTO(TestStringPieceComparisons);
TESTCASE_AUTO(TestStringPieceOther);
#if U_HAVE_STRING_VIEW
#ifdef U_HAVE_STRING_VIEW
TESTCASE_AUTO(TestStringPieceStringView);
#endif
TESTCASE_AUTO(TestByteSink);
@ -433,7 +433,7 @@ StringTest::TestStringPieceOther() {
assertEquals("data()", piece.data(), other.data());
}
#if U_HAVE_STRING_VIEW
#ifdef U_HAVE_STRING_VIEW
void
StringTest::TestStringPieceStringView() {
static constexpr char msg[] = "Kapow!";

2
icu4c/source/test/intltest/strtest.h
View file

@ -45,7 +45,7 @@ private:
void TestStringPiece();
void TestStringPieceComparisons();
void TestStringPieceOther();
#if U_HAVE_STRING_VIEW
#ifdef U_HAVE_STRING_VIEW
void TestStringPieceStringView();
#endif
void TestByteSink();